Bugzilla – Full Text Bug Listing
| Summary: | [refactoring] Pull Up Method makes a class abstract and does not remove method from its origin class | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Jonhnanthan Oliveira <jonhnanthan> |
| Component: | UI | Assignee: | Jeff Johnston <jjohnstn> |
| Status: | CLOSED WORKSFORME | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | jjohnstn |
| Version: | 4.5.2 | ||
| Target Milestone: | 4.11 M3 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
Using latest JDT 4.11 master repo and clicking on the Pull Up... refactoring for method m in B: 1. the abstract long m() declaration in B is removed 2. the changing of class A to abstract and the removal from B are both previewed so the user can choose to cancel Resolving as WORKSFORME. Marking as CLOSED instead of RESOLVED. |
Applying pull up method refactoring to move B.m to class A, makes A abstract and do not remove the method from B. Making a class abstract may be not safe in some domains, such as library (API) developments. Even, in other domains, the developer may not want to make a class abstract. I think at least Eclipse should report a message to allow the user choosing between make a class abstract or give up the transformation. Furthermore, Eclipse does not remove the method from B. It is an error of the refactoring application. The Pull Up Method intention is related to remove the method from subclass and insert in the superclass. --- Before Refactoring: public class A {} public abstract class B extends A { abstract long m(); } --- Resulting Program: public abstract class A { abstract long m(); } public abstract class B extends A { abstract long m(); }