Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 530788

Summary:	Ensure that Orion does not hang in the presence of Ad Blockers
Product:	[ECD] Orion	Reporter:	Steve Northover <steve_northover>
Component:	Client	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	critical
Priority:	P2
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Steve Northover

2018-02-06 10:26:15 EST

Orion should not hang when the user has an Ad blocker installed.  

For example, AdBlockPlus blocks Orion from loading <host>:8888/plugins/googleAnalyticsPlugin.js, after which Orion startup hangs. If you disable the plugin and reload it works fine.

Comment 1 Steve Northover

2018-02-06 10:27:26 EST

This may be the cause of other hangs we have been seeing in customer environments.

Comment 2 Steve Northover

2018-02-06 11:02:58 EST

Funny, this used to fail for me all the time and now it doesn't ...

Comment 3 Silenio Quarti

2018-02-06 11:28:41 EST

I tried AdBlock and AdBlockPlus and they do not seem to block our google analytics plugin.

Comment 4 Steve Northover

2018-02-07 09:15:27 EST

Silenio, please put the results of your investigation in this bug report (ie. some ad blockers looking for any file called googleAnalyticsPlugin)

Comment 5 Silenio Quarti

2018-02-07 13:10:07 EST

If someone adds https://easylist.to/easylist/easyprivacy.txt to the filter list of AdBlockPlus and run orion with non-minified client code, our file https://github.com/eclipse/orion.client/blob/master/bundles/org.eclipse.orion.client.ui/web/plugins/googleAnalyticsPlugin.js will be blocked because the list includes this rule (/GoogleAnalyticsPlugIn.).  The main orion plugin (orionPlugin.html) fails to load because that dependent file is not found and the page hangs.

We could rename this dev file, but it is unlikely the code will run in any production environment without minification.