Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 530623

Summary:	Regression: Linting Rules are unexpectedly removed
Product:	[ECD] Orion	Reporter:	Carolyn MacLeod <Carolyn_MacLeod>
Component:	JS Tools	Assignee:	Carolyn MacLeod <Carolyn_MacLeod>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Michael_Rennie
Version:	unspecified
Target Milestone:	18.0
Hardware:	PC
OS:	Windows 7
See Also:	https://github.com/eclipse/orion.client/pull/293
Whiteboard:

Description Carolyn MacLeod

2018-02-01 12:14:19 EST

The fix for bug 511126 introduced a new bug when trying to ensure that we don't show upstream errors for unknown rules.
Need to change if(!Rules.defaults[key]) to if(!Rules.defaults.hasOwnProperty(key)).

Comment 1 Eclipse Genie

2018-02-01 12:19:23 EST

GitHub Pull Request 293 created by [carmacleod]
https://github.com/eclipse/orion.client/pull/293

Comment 2 Michael Rennie

2018-02-02 09:05:00 EST

PR has been merged. Closing.