Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 530431

Summary:	Add standard diagram services to avoid duplicated code
Product:	[Modeling] Sirius	Reporter:	Laurent Redor <laurent.redor>
Component:	Diagram	Assignee:	Laurent Redor <laurent.redor>
Status:	CLOSED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	maxime.porhel, pierre-charles.david
Version:	5.1.0	Keywords:	triaged
Target Milestone:	6.1.0
Hardware:	PC
OS:	Windows 10
See Also:	https://git.eclipse.org/r/116204 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7d1c04a1e090c5cc0df13bf7b743afa551662559 https://git.eclipse.org/r/122039 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7eda213928c99cf1e5ab1dbea74a36df73c24222
Whiteboard:
Bug Depends on:
Bug Blocks:	533318

Description Laurent Redor

2018-01-29 02:09:17 EST

Some services can be defined several times in different modeler defined with Sirius. To avoid them, it could be interesting to have a standard diagram services class, as it is the case for Sirius Core (org.eclipse.sirius.common.tools.api.interpreter.StandardServices).

In a first time, this class could contain services to retreive DDiagramElement according to:
* the type of the current selected elements
* the mapping of the current selected elements
* a selected type by the end-user
* an expression given by the end-user

Comment 1 Eclipse Genie

2018-01-29 02:38:19 EST

New Gerrit change created: https://git.eclipse.org/r/116204

Comment 2 Eclipse Genie

2018-01-29 03:36:32 EST

Gerrit change https://git.eclipse.org/r/116204 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7d1c04a1e090c5cc0df13bf7b743afa551662559

Comment 3 Laurent Redor

2018-01-29 03:37:26 EST

The above commit is a first commit for this issue. It's a POC and will be improved later.

Comment 4 Eclipse Genie

2018-05-02 12:54:57 EDT

New Gerrit change created: https://git.eclipse.org/r/122039

Comment 5 Eclipse Genie

2018-05-03 09:44:19 EDT

Gerrit change https://git.eclipse.org/r/122039 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7eda213928c99cf1e5ab1dbea74a36df73c24222

Comment 6 Laurent Redor

2018-09-25 13:57:05 EDT

There is no real validation as it is a cherry-pick of a POC (some services available here will be tested in bug 534302).

Comment 7 Pierre-Charles David

2018-10-19 12:48:22 EDT

Available in Sirius 6.1.0, see https://wiki.eclipse.org/Sirius/6.1.0