| Summary: | Synchronization decorator is messing with zoom functionality | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Pierre Guilet <pierre.guilet> | ||||||
| Component: | Diagram | Assignee: | Pierre Guilet <pierre.guilet> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | florian.barbin, laurent.fasani, pierre-charles.david | ||||||
| Version: | 5.1.0 | Keywords: | triaged | ||||||
| Target Milestone: | 6.0.0 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 10 | ||||||||
| See Also: |
https://git.eclipse.org/r/115715 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c74b96f51098514fc53e4ac91022891d77486fe4 https://git.eclipse.org/r/123322 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=91c0e6d93c910c0f6fac439a3d0384e2a73d005f |
||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 531188, 535390 | ||||||||
| Attachments: |
|
||||||||
New Gerrit change created: https://git.eclipse.org/r/115715 Update of the steps to reproduce 1- Import the attached project 2- Tick Preference Sirius/Sirius Diagram/Show synchronize status decorator diagram 2- open the representation 3- Zoom to 25 using the Page zoom in the tabbar 4- Zoom to 100 using the Page zoom in the tabbar KO the diagram element is not visible anymore. The horizontal and vertical scroll bar are displayed whereas they should not. Gerrit change https://git.eclipse.org/r/115715 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c74b96f51098514fc53e4ac91022891d77486fe4 Not validated with the following step to reproduce: 1- Import the attached project 2- Tick Preference Sirius/Sirius Diagram/Show synchronize status decorator diagram 3- open the representation 4- Zoom to 25 using the combo box 5- Zoom to 100 using the Zoom In button KO, The Zoom In button seems to taking into account the sychronize status decorator. The horizontal and vertical scrollbars are activated and the element is not displayed. New Gerrit change created: https://git.eclipse.org/r/123322 Gerrit change https://git.eclipse.org/r/123322 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=91c0e6d93c910c0f6fac439a3d0384e2a73d005f Fixed by 91c0e6d93c910c0f6fac439a3d0384e2a73d005f. Verified with OD CE 11 RC2 The zoom button to use for Guillaume scenario is the one in the tabbar. Created attachment 274274 [details]
project to reproduce
Not the one to be verified Known bug regarding the zoom with synchronized decorator that will be fixed in 5.1.3: https://bugs.eclipse.org/bugs/show_bug.cgi?id=535390 last comment is not for this ticket version. Available in Sirius 6.0.0, see https://wiki.eclipse.org/Sirius/6.0.0 for details |
Created attachment 272342 [details] project to reproduce Doing a page zoom while the synchronization decorator is visible will impact the zoom result badly. The decorator will be taken in consideration when computing the resulting viewport so if the decorator is below the lower diagram element, the zoom will be done to see this decorator. Steps to reproduce: 1- Import the attached project 2- open the representation 3- Zoom to 25 4- Use the Page zoom in the tabbar KO the diagram element is not near the editor's bottom. This is the synchronization decorator that is.