Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 530051

Summary: Synchronization decorator is messing with zoom functionality
Product: [Modeling] Sirius Reporter: Pierre Guilet <pierre.guilet>
Component: DiagramAssignee: Pierre Guilet <pierre.guilet>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: florian.barbin, laurent.fasani, pierre-charles.david
Version: 5.1.0Keywords: triaged
Target Milestone: 6.0.0   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/115715
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c74b96f51098514fc53e4ac91022891d77486fe4
https://git.eclipse.org/r/123322
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=91c0e6d93c910c0f6fac439a3d0384e2a73d005f
Whiteboard:
Bug Depends on:    
Bug Blocks: 531188, 535390    
Attachments:
Description Flags
project to reproduce
none
project to reproduce none

Description Pierre Guilet CLA 2018-01-19 12:14:55 EST
Created attachment 272342 [details]
project to reproduce

Doing a page zoom while the synchronization decorator is visible will impact the zoom result badly. The decorator will be taken in consideration when computing the resulting viewport so if the decorator is below the lower diagram element, the zoom will be done to see this decorator.

Steps to reproduce:
1- Import the attached project
2- open the representation 
3- Zoom to 25
4- Use the Page zoom in the tabbar
KO the diagram element  is not near the editor's bottom. This is the synchronization decorator that is.
Comment 1 Eclipse Genie CLA 2018-01-19 12:19:37 EST
New Gerrit change created: https://git.eclipse.org/r/115715
Comment 2 Laurent Fasani CLA 2018-01-25 04:45:43 EST
Update of the steps to reproduce
1- Import the attached project
2- Tick Preference Sirius/Sirius Diagram/Show synchronize status decorator diagram
2- open the representation 
3- Zoom to 25 using the Page zoom in the tabbar
4- Zoom to 100 using the Page zoom in the tabbar
KO the diagram element  is not visible anymore. The horizontal and vertical scroll bar are displayed whereas they should not.
Comment 4 Guillaume Coutable CLA 2018-05-24 08:16:18 EDT
Not validated with the following step to reproduce: 
1- Import the attached project
2- Tick Preference Sirius/Sirius Diagram/Show synchronize status decorator diagram
3- open the representation 
4- Zoom to 25 using the combo box
5- Zoom to 100 using the Zoom In button

KO, The Zoom In button seems to taking into account the sychronize status decorator. The horizontal and vertical scrollbars are activated and the element is not displayed.
Comment 5 Eclipse Genie CLA 2018-05-25 06:02:45 EDT
New Gerrit change created: https://git.eclipse.org/r/123322
Comment 7 Pierre-Charles David CLA 2018-05-28 08:38:36 EDT
Fixed by 91c0e6d93c910c0f6fac439a3d0384e2a73d005f.
Comment 8 Pierre Guilet CLA 2018-05-31 04:41:48 EDT
Verified with OD CE 11 RC2

The zoom button to use for Guillaume scenario is the one in the tabbar.
Comment 9 Pierre Guilet CLA 2018-05-31 04:43:28 EDT
Created attachment 274274 [details]
project to reproduce
Comment 10 Pierre Guilet CLA 2018-05-31 04:45:52 EDT
Not the one to be verified
Comment 11 Pierre Guilet CLA 2018-05-31 08:49:18 EDT
Known bug regarding the zoom with synchronized decorator that will be fixed in 5.1.3:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=535390
Comment 12 Pierre Guilet CLA 2018-05-31 08:55:08 EDT
last comment is not for this ticket version.
Comment 13 Laurent Redor CLA 2018-06-27 11:55:08 EDT
Available in Sirius 6.0.0, see https://wiki.eclipse.org/Sirius/6.0.0 for details