Bugzilla – Full Text Bug Listing
| Summary: | Improve Sirius Popup Menu contributions | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Laurent Redor <laurent.redor> | ||||||||||||||
| Component: | Diagram | Assignee: | Project Inbox <sirius.diagram-inbox> | ||||||||||||||
| Status: | CLOSED FIXED | QA Contact: | Laurent Redor <laurent.redor> | ||||||||||||||
| Severity: | enhancement | ||||||||||||||||
| Priority: | P3 | CC: | julien.dupont, pierre.guilet | ||||||||||||||
| Version: | 5.1.0 | Keywords: | triaged | ||||||||||||||
| Target Milestone: | 5.1.2 | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | Windows 10 | ||||||||||||||||
| See Also: |
https://git.eclipse.org/r/121152 https://git.eclipse.org/r/121366 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=41262564155c59570f6a40146313368797c7886e https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bb1e189d37cc4722da4b24f22b930c5fac4236ea |
||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 533654, 534301, 534302 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Laurent Redor
Created attachment 272329 [details]
newSeparator.png
Created attachment 272330 [details]
newActionsInExistingMenu.png
Another improvement will be to contribute additional actions to existing menus to the tabbar. A first need would be to add selection actions to the "Select All" menu of the tabbar. New Gerrit change created: https://git.eclipse.org/r/121152 Created attachment 273595 [details]
POC_contextualMenu.png
POC_contextualMenu.png: Result that can be observed with the sample project org.eclipse.sirius.sample.popupmenu and the above gerrit.
Created attachment 273596 [details]
Project org.eclipse.sirius.sample.popupmenu
Project org.eclipse.sirius.sample.popupmenu: Sample project that uses documentation property of "Popup Menu" and "Operation Action" to utilize the new mechanism offered by the above POC. A documentation will be added later to explain what is possible to do.
This POC demonstrates what is possible to do.
Created attachment 273638 [details]
contextualMenu_withoutPOC.png
contextualMenu_withoutPOC.png: Same contextual menu but without the POC enabled. All the menu are at the end of the contextual menu and without group.
(In reply to Eclipse Genie from comment #4) > New Gerrit change created: https://git.eclipse.org/r/121152 This gerrit is a POC and to be activated the VM argument "-Dorg.eclipse.sirius.experimental.popupMenuImprovement=true" must be added. It currently does not covered this part of initial description: > * Capability to define the insertion point of the popup menu or of the actions. A bit like what is done for the extension point org.eclipse.ui.menus [4]. New Gerrit change created: https://git.eclipse.org/r/121366 (In reply to Laurent Redor from comment #3) > Another improvement will be to contribute additional actions to existing > menus to the tabbar. A first need would be to add selection actions to the > "Select All" menu of the tabbar. It is now possible with the above gerrit (see bug 533654 comment 6 to see how to test it). (In reply to Laurent Redor from comment #10) > (In reply to Laurent Redor from comment #3) > > Another improvement will be to contribute additional actions to existing > > menus to the tabbar. A first need would be to add selection actions to the > > "Select All" menu of the tabbar. > It is now possible with the above gerrit (see bug 533654 comment 6 to see > how to test it). A tooltip now appears with the gerrit when using the tabbar to execute a select all action when the functionality is activated with the system property. This is OK for the POC but a better solution should be found later. Gerrit change https://git.eclipse.org/r/121366 was merged to [v5.1.x]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=41262564155c59570f6a40146313368797c7886e Gerrit change https://git.eclipse.org/r/121152 was merged to [v5.1.x]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bb1e189d37cc4722da4b24f22b930c5fac4236ea Currently, the work on this POC is interrupted. The first iteration is considered as ended. Another issue will be created to continue the work on this subject. So I close this issue as resolved. There is no real validation as it is a POC. Available in Sirius 5.1.2, see https://wiki.eclipse.org/Sirius/5.1.2 for details |