Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 529497

Summary: Update ASM to version 6 in PDE in 4.7.3 and update the code accordingly
Product: [Eclipse Project] PDE Reporter: Vikas Chandra <Vikas.Chandra>
Component: API ToolsAssignee: Vikas Chandra <Vikas.Chandra>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 4.8   
Target Milestone: 4.7.3   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/115673
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=3dbb38af8a2f844fc6f23c6dd349ab0ab755d5ab
https://git.eclipse.org/r/115674
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=1b3579763db263720cb9183e5315b424e3dc7448
https://git.eclipse.org/r/116083
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=f3a2647f03e0870739e6afb6c9662d53b1c9f0e2
Whiteboard:
Bug Depends on: 529294    
Bug Blocks:    
Attachments:
Description Flags
Update version range
none
update ASM 6 code none

Description Vikas Chandra CLA 2018-01-08 00:45:56 EST 
When Bug 529294 is put in 4.7.3, PDE should update the version ranges accordingly
and all code where Opcodes.ASM5 is present should be updated to Opcodes.ASM6.
Comment 1 Vikas Chandra CLA 2018-01-08 01:03:38 EST 
Created attachment 272158 [details]
Update version range
Comment 2 Vikas Chandra CLA 2018-01-08 01:16:31 EST 
Created attachment 272159 [details]
update ASM 6 code
Comment 3 Eclipse Genie CLA 2018-01-19 03:15:24 EST 
New Gerrit change created: https://git.eclipse.org/r/115673
Comment 4 Eclipse Genie CLA 2018-01-19 03:17:36 EST 
Gerrit change https://git.eclipse.org/r/115673 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=3dbb38af8a2f844fc6f23c6dd349ab0ab755d5ab
Comment 5 Eclipse Genie CLA 2018-01-19 03:18:50 EST 
New Gerrit change created: https://git.eclipse.org/r/115674
Comment 6 Eclipse Genie CLA 2018-01-19 03:19:02 EST 
Gerrit change https://git.eclipse.org/r/115674 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=1b3579763db263720cb9183e5315b424e3dc7448
Comment 7 Vikas Chandra CLA 2018-01-19 07:37:21 EST 
Need to track the next M build to check if this is picked up.
Comment 8 Vikas Chandra CLA 2018-01-26 01:54:01 EST 
Verified on
Version: Oxygen.3 (4.7.3)
Build id: M20180125-0335
Comment 9 Eclipse Genie CLA 2018-01-26 02:12:28 EST 
New Gerrit change created: https://git.eclipse.org/r/116083
Comment 10 Eclipse Genie CLA 2018-01-26 02:22:16 EST 
Gerrit change https://git.eclipse.org/r/116083 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=f3a2647f03e0870739e6afb6c9662d53b1c9f0e2