Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 527848

Summary: [Quick Access] IllegalStateException in Quick Access popup
Product: [Eclipse Project] Platform Reporter: Noopur Gupta <noopur_gupta>
Component: UIAssignee: Mickael Istria <mistria>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: daniel_megert, lshanmug
Version: 4.8   
Target Milestone: 4.8 M4   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/112568
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=327db0d5beb6c00c8f39e4832207dddc1c9b7a06
Whiteboard:
Bug Depends on: 526480    
Bug Blocks:    

Description Noopur Gupta CLA 2017-11-28 03:59:02 EST
- Open Quick access by pressing Ctrl+3 and type "new m" (without quotes). We get this exception in the Error Log:

eclipse.buildId=4.8.0.I20171126-2000
java.version=1.8.0_151
java.vendor=Oracle Corporation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en_US
Command-line arguments:  -os win32 -ws win32 -arch x86_64

org.eclipse.ui
Error
Tue Nov 28 14:23:13 IST 2017
Unhandled event loop exception

java.lang.IllegalStateException: No match available
	at java.util.regex.Matcher.start(Unknown Source)
	at org.eclipse.ui.internal.quickaccess.QuickAccessElement.match(QuickAccessElement.java:213)
	at org.eclipse.ui.internal.quickaccess.QuickAccessContents.computeMatchingEntries(QuickAccessContents.java:465)
	at org.eclipse.ui.internal.quickaccess.QuickAccessContents.refresh(QuickAccessContents.java:143)
	at org.eclipse.ui.internal.quickaccess.QuickAccessContents.lambda$2(QuickAccessContents.java:659)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:180)
...
Comment 1 Noopur Gupta CLA 2017-11-28 05:26:23 EST
We get this exception whenever a space is typed in the Quick Access field e.g. "Git Staging". 

Sometimes the Quick Access popup crashes with this exception without showing/opening the result.
Comment 2 Noopur Gupta CLA 2017-11-28 05:35:39 EST
Reverting the commit from bug 526480 comment #3 fixes the issue.

Mickael, please have a look.
Comment 3 Lakshmi P Shanmugam CLA 2017-11-29 07:42:56 EST
I ran into the same problem on Mac and happens with the latest I-build too. Everytime I type space in QuickAccess, IllegalStateException state exception is logged in the Error Log and no matching happens for the second word.
Comment 4 Mickael Istria CLA 2017-11-29 07:54:01 EST
I managed to reproduce it in some automated test and will provide a patch later today.
Comment 5 Eclipse Genie CLA 2017-11-29 10:03:58 EST
New Gerrit change created: https://git.eclipse.org/r/112568
Comment 7 Mickael Istria CLA 2017-12-03 13:38:01 EST
Thanks for the review/merge Andrey!