| Summary: | Entries in error log: org.eclipse.update.configurator - Could not install bundle... | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Noopur Gupta <noopur_gupta> | ||||
| Component: | IDE | Assignee: | Alexander Kurtakov <akurtakov> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | akurtakov, armin.beil, bsd, daniel_megert, sbouchet | ||||
| Version: | 4.8 | ||||||
| Target Milestone: | 4.8 M4 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| See Also: |
https://git.eclipse.org/r/112486 https://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=bca37abc53dfd293c1b750c5c9844f7cd905ddf8 https://git.eclipse.org/r/112527 https://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=9f7c3d67025c6ae4ea91e8f80d661664fa2cd57c https://bugs.eclipse.org/bugs/show_bug.cgi?id=542706 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 542706 | ||||||
| Attachments: |
|
||||||
|
Description
Noopur Gupta
Hmm, I just did it and I don't see any such entry? What step could I be missing? I can see this in Windows 7 and macOS. It doesn't happen in Ubuntu 16.04. I can see the same messages in Console view also (in Windows and macOS) while launching a runtime workbench from the main Eclipse. So this happens only on win and mac ? (In reply to Alexander Kurtakov from comment #4) > So this happens only on win and mac ? Yes, looks like that's the case. I tried on Ubuntu 16.04 and it didn't happen there. Also, when I have some plug-ins (e.g. org.eclipse.ui) imported from Git repo in my workspace, launching a runtime workbench gives the following error messages in Console view along with the entries from comment #0: !ENTRY org.eclipse.ui 4 0 2017-11-28 18:18:06.081 !MESSAGE FrameworkEvent ERROR !STACK 0 org.osgi.framework.BundleException: Could not resolve module: org.eclipse.ui [2708] Another singleton bundle selected: osgi.identity; type="osgi.bundle"; version:Version="3.109.100.qualifier"; osgi.identity="org.eclipse.ui"; singleton:="true" at org.eclipse.osgi.container.Module.start(Module.java:444) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1550) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1) at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340) Noopur, would you please upload the whole .log file? Created attachment 271678 [details] log file (In reply to Alexander Kurtakov from comment #7) > Noopur, would you please upload the whole .log file? Attached from Windows 7 based on steps from comment #0. Does it happen with clean installs or only with updated? Is it removed if launched with -clean ? (In reply to Alexander Kurtakov from comment #9) > Does it happen with clean installs or only with updated? It happens with freshly downloaded builds i.e. clean installs. I haven't tried by updating builds. > Is it removed if launched with -clean ? Launching with -clean also logs the same entries. Do you actually have update.configurator in your plugins folder? New Gerrit change created: https://git.eclipse.org/r/112486 Gerrit change https://git.eclipse.org/r/112486 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=bca37abc53dfd293c1b750c5c9844f7cd905ddf8 OK, I figured it out p2 explicitly disables update.configurator reconciling which was removed. Reverted now. Dani, what do you think of removing update.configurator reconciling code? If it's explicitly disabled everytime we would better play safe and remove it direclty. New Gerrit change created: https://git.eclipse.org/r/112527 Gerrit change https://git.eclipse.org/r/112527 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=9f7c3d67025c6ae4ea91e8f80d661664fa2cd57c I have just verified it no longer happens on Win 10. It doesn't happen now on Windows 7 and macOS 10.5 with I20171129-2000. This change broke applications that don't use p2 to install bundles (bug 542706, https://www.eclipse.org/forums/index.php/m/1800976/). An alternative solution to this bug would be to change ConfigurationActivator#isReconciling() to default to false unless explicitly enabled? /** * Returns whether the update configurator should be doing its own reconciling work */ public static boolean isReconciling() { String reconcile = context.getProperty("org.eclipse.update.reconcile"); //$NON-NLS-1$ // OLD: return reconcile == null || reconcile.equalsIgnoreCase("true"); //$NON-NLS-1$ return reconcile != null && reconcile.equalsIgnoreCase("true"); //$NON-NLS-1$ } (And the change to PlatformConfiguration in https://git.eclipse.org/r/112527 seems unrelated?) (In reply to Brian de Alwis from comment #19) > This change broke applications that don't use p2 to install bundles (bug > 542706, https://www.eclipse.org/forums/index.php/m/1800976/). > > An alternative solution to this bug would be to change > ConfigurationActivator#isReconciling() to default to false unless explicitly > enabled? > > /** > * Returns whether the update configurator should be doing its own > reconciling work > */ > public static boolean isReconciling() { > String reconcile = context.getProperty("org.eclipse.update.reconcile"); > //$NON-NLS-1$ > // OLD: return reconcile == null || reconcile.equalsIgnoreCase("true"); > //$NON-NLS-1$ > return reconcile != null && reconcile.equalsIgnoreCase("true"); > //$NON-NLS-1$ > } > > (And the change to PlatformConfiguration in https://git.eclipse.org/r/112527 > seems unrelated?) Update.configurator has been deprecated for almost 10 years now. Spending anytime on bringing parts of it back is time lost. People that want similar functionality should use dropins and/or droplets(https://wiki.eclipse.org/Equinox/p2/P2_Fragments). I saw your comment that these are deprecated but update.configurator is way more deprecated. |