Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 527783

Summary: Entries in error log: org.eclipse.update.configurator - Could not install bundle...
Product: [Eclipse Project] Platform Reporter: Noopur Gupta <noopur_gupta>
Component: IDEAssignee: Alexander Kurtakov <akurtakov>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, armin.beil, bsd, daniel_megert, sbouchet
Version: 4.8   
Target Milestone: 4.8 M4   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/112486
https://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=bca37abc53dfd293c1b750c5c9844f7cd905ddf8
https://git.eclipse.org/r/112527
https://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=9f7c3d67025c6ae4ea91e8f80d661664fa2cd57c
https://bugs.eclipse.org/bugs/show_bug.cgi?id=542706
Whiteboard:
Bug Depends on:    
Bug Blocks: 542706    
Attachments:
Description Flags
log file none

Description Noopur Gupta CLA 2017-11-27 05:34:27 EST
With I20171126-2000, open a new workspace and open the Error Log view.

I see many entries in the Error Log view like:

org.eclipse.update.configurator
Error
Mon Nov 27 15:44:15 IST 2017
Could not install bundle plugins/org.eclipse.ui.workbench_3.111.0.v20171124-1003.jar   A bundle is already installed with the name "org.eclipse.ui.workbench" and version "3.111.0.v20171124-1003"
Comment 1 Alexander Kurtakov CLA 2017-11-27 06:03:11 EST
Hmm, I just did it and I don't see any such entry? What step could I be missing?
Comment 2 Noopur Gupta CLA 2017-11-27 08:42:49 EST
I can see this in Windows 7 and macOS.
Comment 3 Noopur Gupta CLA 2017-11-28 07:18:33 EST
It doesn't happen in Ubuntu 16.04.

I can see the same messages in Console view also (in Windows and macOS) while launching a runtime workbench from the main Eclipse.
Comment 4 Alexander Kurtakov CLA 2017-11-28 07:29:42 EST
So this happens only on win and mac ?
Comment 5 Noopur Gupta CLA 2017-11-28 07:36:00 EST
(In reply to Alexander Kurtakov from comment #4)
> So this happens only on win and mac ?

Yes, looks like that's the case. I tried on Ubuntu 16.04 and it didn't happen there.
Comment 6 Noopur Gupta CLA 2017-11-28 08:01:24 EST
Also, when I have some plug-ins (e.g. org.eclipse.ui) imported from Git repo in my workspace, launching a runtime workbench gives the following error messages in Console view along with the entries from comment #0:

!ENTRY org.eclipse.ui 4 0 2017-11-28 18:18:06.081
!MESSAGE FrameworkEvent ERROR
!STACK 0
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.ui [2708]
  Another singleton bundle selected: osgi.identity; type="osgi.bundle"; version:Version="3.109.100.qualifier"; osgi.identity="org.eclipse.ui"; singleton:="true"

	at org.eclipse.osgi.container.Module.start(Module.java:444)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1550)
	at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
	at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
	at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
Comment 7 Alexander Kurtakov CLA 2017-11-28 09:47:06 EST
Noopur, would you please upload the whole .log file?
Comment 8 Noopur Gupta CLA 2017-11-28 09:55:23 EST
Created attachment 271678 [details]
log file

(In reply to Alexander Kurtakov from comment #7)
> Noopur, would you please upload the whole .log file?

Attached from Windows 7 based on steps from comment #0.
Comment 9 Alexander Kurtakov CLA 2017-11-28 10:24:38 EST
Does it happen with clean installs or only with updated? Is it removed if launched with -clean ?
Comment 10 Noopur Gupta CLA 2017-11-28 10:30:50 EST
(In reply to Alexander Kurtakov from comment #9)
> Does it happen with clean installs or only with updated? 
It happens with freshly downloaded builds i.e. clean installs. I haven't tried by updating builds. 

> Is it removed if launched with -clean ?
Launching with -clean also logs the same entries.
Comment 11 Alexander Kurtakov CLA 2017-11-28 11:18:23 EST
Do you actually have update.configurator in your plugins folder?
Comment 12 Eclipse Genie CLA 2017-11-28 13:59:41 EST
New Gerrit change created: https://git.eclipse.org/r/112486
Comment 14 Alexander Kurtakov CLA 2017-11-28 14:20:46 EST
OK, I figured it out p2 explicitly disables update.configurator reconciling which was removed. Reverted now. 
Dani, what do you think of removing update.configurator reconciling code? If it's explicitly disabled everytime we would better play safe and remove it direclty.
Comment 15 Eclipse Genie CLA 2017-11-29 01:35:11 EST
New Gerrit change created: https://git.eclipse.org/r/112527
Comment 17 Alexander Kurtakov CLA 2017-11-30 02:11:26 EST
I have just verified it no longer happens on Win 10.
Comment 18 Noopur Gupta CLA 2017-11-30 04:38:06 EST
It doesn't happen now on Windows 7 and macOS 10.5 with I20171129-2000.
Comment 19 Brian de Alwis CLA 2019-01-10 09:38:14 EST
This change broke applications that don't use p2 to install bundles (bug 542706, https://www.eclipse.org/forums/index.php/m/1800976/).  

An alternative solution to this bug would be to change  ConfigurationActivator#isReconciling() to default to false unless explicitly enabled? 

  /**
   * Returns whether the update configurator should be doing its own reconciling work
   */
  public static boolean isReconciling() {
  	String reconcile = context.getProperty("org.eclipse.update.reconcile"); //$NON-NLS-1$
  	// OLD: return reconcile == null || reconcile.equalsIgnoreCase("true"); //$NON-NLS-1$
  	return reconcile != null && reconcile.equalsIgnoreCase("true"); //$NON-NLS-1$
  }

(And the change to PlatformConfiguration in https://git.eclipse.org/r/112527 seems unrelated?)
Comment 20 Alexander Kurtakov CLA 2019-01-15 11:20:39 EST
(In reply to Brian de Alwis from comment #19)
> This change broke applications that don't use p2 to install bundles (bug
> 542706, https://www.eclipse.org/forums/index.php/m/1800976/).  
> 
> An alternative solution to this bug would be to change 
> ConfigurationActivator#isReconciling() to default to false unless explicitly
> enabled? 
> 
>   /**
>    * Returns whether the update configurator should be doing its own
> reconciling work
>    */
>   public static boolean isReconciling() {
>   	String reconcile = context.getProperty("org.eclipse.update.reconcile");
> //$NON-NLS-1$
>   	// OLD: return reconcile == null || reconcile.equalsIgnoreCase("true");
> //$NON-NLS-1$
>   	return reconcile != null && reconcile.equalsIgnoreCase("true");
> //$NON-NLS-1$
>   }
> 
> (And the change to PlatformConfiguration in https://git.eclipse.org/r/112527
> seems unrelated?)

Update.configurator has been deprecated for almost 10 years now. Spending anytime on bringing parts of it back is time lost. People that want similar functionality should use dropins and/or droplets(https://wiki.eclipse.org/Equinox/p2/P2_Fragments). I saw your comment that these are deprecated but update.configurator is way more deprecated.