Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 527737 (webkit2excuteShouldNotBeWrapped)

Summary: [Webkit2] regression, execute() script should not be wrapped into a function
Product: [Eclipse Project] Platform Reporter: Leo Ufimtsev <lufimtse>
Component: SWTAssignee: Leo Ufimtsev <lufimtse>
Status: RESOLVED FIXED QA Contact: Leo Ufimtsev <lufimtse>
Severity: normal    
Priority: P3 CC: lufimtse, platform-swt-inbox
Version: 4.8   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/112387
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=e0adde8886a7184673f03e859438d57750ed19a0
Whiteboard:
Bug Depends on:    
Bug Blocks: 516838, 527564    

Description Leo Ufimtsev CLA 2017-11-24 15:01:35 EST 
After investigation, I found that webkit2 closes snippet326 without showing the 'would you like to cancel ' functionality.

It seems 'close()' throws an swt exception saying that the temporary function cannot be found.
This used to work on webkit2 (I think?). I think it's possible that the fix for jboss I did a while back that modified execute() and wrapped functions into a wrapper caused this regression.

I.e, it seems that if you use 'execute()', then you can't register functions properly as they're wrapped inside a temporary function.

Need to figure out some way around this..
Comment 1 Eclipse Genie CLA 2017-11-27 17:09:23 EST 
New Gerrit change created: https://git.eclipse.org/r/112387
Comment 2 Leo Ufimtsev CLA 2017-11-27 17:10:37 EST 
(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/112387

Fixed up the issue. Awaiting parent patch to be merged and then I'll merge in this guy also.
(parent being: https://git.eclipse.org/r/#/c/110256/)
Comment 3 Leo Ufimtsev CLA 2017-12-01 13:47:21 EST 
if BrowserFunction works well, then I'll merge this on Monday-ish.