Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 527565 (webkit2SnippetVerification)

Summary: [Webkit2] Ensure all Browser Snippets work.
Product: [Eclipse Project] Platform Reporter: Leo Ufimtsev <lufimtse>
Component: SWTAssignee: Leo Ufimtsev <lufimtse>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: platform-swt-inbox, rgrunber
Version: 4.8   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/112273
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5831af8f26da363d280912b9e2d1e4b20bb2b72a
Whiteboard: RHT
Bug Depends on:    
Bug Blocks: 516838    
Attachments:
Description Flags
Snippet verification notes. none

Description Leo Ufimtsev CLA 2017-11-21 11:49:47 EST 
To ensure webkit2 port works well, we should verify that all BrowserSnippets work. (At least those that worked on Webkit1 should also work on webkit2):

(See "Browser" section:)
https://www.eclipse.org/swt/snippets/
Comment 1 Eclipse Genie CLA 2017-11-24 14:00:48 EST 
New Gerrit change created: https://git.eclipse.org/r/112273
Comment 3 Leo Ufimtsev CLA 2017-11-24 15:10:03 EST 
Found that 1 snippet broke on webkit2 (regression) and one didn't work (not implemented).

Created bugs to deal with them.

Regression:
Bug 527737 – [Webkit2] Snippet326 is not showing a close dialogue 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=527737

Needs porting/implementation:
Bug 527565 – [Webkit2] Ensure all Browser Snippets work. 
https://bugs.eclipse.org/bugs/show_bug.cgi?id=527565

Everything else (at least the non-mozilla, post 3.5) snippets work.

[X] check if the browser is available or not
[X] bring up a browser (single window)
[X] bring up a browser with pop-up blocker
[X] bring up a browser with pop-up window support
[X] render HTML from memory
[x] render HTML that includes relative links from memory
[X] render HTML from memory in response to a link click
[NA] listen for DOM mousedown events with JavaScript (SWT 3.4 and earlier)
[X] listen for DOM mousedown events with JavaScript (SWT 3.5 and newer)
[X] modify DOM (execute JavaScript)
[NA] query DOM node value (SWT 3.4 and earlier)
[X] query DOM node value (SWT 3.5 and newer)
[X] modify HTML title tag
[X] provide credentials for a basic authentication challenge
[X] call Java from JavaScript
[!] close a Browser such that it can be cancelled by an onbeforeunload handler
  Snippet326 
    Webkit1 shows dialogue prior to closing.
    Webkit2 closes without proving option to not dispose.

[!] send custom headers and post data with HTTP requests
  Snippet330
    Sending data over 'postData' isn't working on webkit2.
    - On webkit1, bugzilla can be queries with postData
    - On webkit2, bugzilla opens with an error message about missing post data.
    Upon code inspection, it seems that postData has not been ported.
    (but headers button seems to work.)
[X] WebKit in a browser
[X] Mozilla in a browser
[NA] toggle a Mozilla Browser between Design mode and View mode
[NA] implement a custom download handler for a Mozilla Browser
[NA] show an HTML element-specific context menu in a Mozilla Browser
[NA] examine request and response headers in a Mozilla Browser
[NA] view DOM tree and edit node values in a Mozilla Browser
[NA] zoom HTML page content in a Mozilla Browser
Comment 4 Leo Ufimtsev CLA 2017-11-28 13:36:06 EST 
Created attachment 271685 [details]
Snippet verification notes.