Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 527563

Summary:	Unencoded search param for 'NameLower' should return 400
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	Node	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P2
Version:	16.0
Target Milestone:	17.0
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Michael Rennie

2017-11-21 11:04:15 EST

If the server is sent a search query like the following:

'sort=Name%20asc&rows=30&start=0&q=NameLower:api.js?onload=loadPicker*+CaseSensitive:true+WholeWord:true+Location:/myserver/prefix/file/foobar@gmail.com-sha1024/javascript/*+Exclude:node_modules&some_extras=one:two:three'

We should be returning a 400 (bad request) instead of catching the exception thrown interally and returning a 500

Comment 1 Michael Rennie

2017-11-21 11:07:37 EST

Fixed in (with unit test):

https://github.com/eclipse/orion.client/commit/d731d7ef0a14efe03ffe268854bc1670c6daca22