Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 527364

Summary: [Aird Editor] Revert a syncCall that causes deadlocks
Product: [Modeling] Sirius Reporter: Steve Monnier <steve.monnier>
Component: CoreAssignee: Maxime Porhel <maxime.porhel>
Status: CLOSED FIXED QA Contact: Steve Monnier <steve.monnier>
Severity: normal    
Priority: P3 CC: maxime.porhel
Version: 5.1.0Keywords: triaged
Target Milestone: 5.1.1   
Hardware: PC   
OS: Windows NT   
See Also: https://git.eclipse.org/r/111817
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9dfac46f3749ed3fe0256ca890d41f83367e0095
Whiteboard:

Description Steve Monnier CLA 2017-11-16 12:12:39 EST 
In org.eclipse.sirius.ui.tools.internal.graphicalcomponents.GraphicalRepresentationHandler.notify(Session, int) an asyncCall was modified in a syncCall to avoid a NPE (see commit 0bb1aee305b5699a45d4be3fadff10c16012551e for bugzilla 510040). However, the scenario was not specified and can't be reproduced anymore. This change needs to be reverted has it is the source of a deadlock scenario in collaborative mode. Ask Steve for the scenario.
Comment 1 Eclipse Genie CLA 2017-11-17 11:38:43 EST 
New Gerrit change created: https://git.eclipse.org/r/111817
Comment 2 Maxime Porhel CLA 2017-11-27 11:08:52 EST 
Patch set has been reviewed and merged. 

No homologation required as there was not initial scenario for the move to a sync call. 

The deadlock scenario will be tested in the product which showed the issue.
See details with Steve.
Comment 3 Maxime Porhel CLA 2017-11-27 11:08:57 EST 
Patch set has been reviewed and merged. 

No homologation required as there was not initial scenario for the move to a sync call. 

The deadlock scenario will be tested in the product which showed the issue.
See details with Steve.
Comment 5 Pierre-Charles David CLA 2018-02-01 03:25:22 EST 
Available in Sirius 5.1.1. See https://wiki.eclipse.org/Sirius/5.1.1 for details.