Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 527313

Summary: Cannot update my own patches
Product: Community Reporter: Salome Maro <salomehonest>
Component: GerritAssignee: Eclipse Webmaster <webmaster>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ec, frederic.gurr, mikael.barbero
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
Whiteboard:
Bug Depends on: 530205    
Bug Blocks:    

Description Salome Maro CLA 2017-11-15 17:13:03 EST
Hi,

I have pushed a patch for review to our project (https://projects.eclipse.org/projects/modeling.capra), however when I try to update the patch I get an error saying "Cannot add patchest". 

I checked that I used the right user and email and I am recognised as a committer. 

I also noticed that, when not logged in to gerrit I can see the change pushed and it shows my correct email but when i log in to gerrit I cannot see the change at all. 

Can anyone help me with this? 

regards,

Salome.
Comment 1 Eclipse Webmaster CLA 2017-11-16 11:17:53 EST
This sounds like https://bugs.eclipse.org/bugs/show_bug.cgi?id=525553 .

I'm going to close this as a dupe, but please reopen if you think it's different.

-M.

*** This bug has been marked as a duplicate of bug 525553 ***
Comment 2 Salome Maro CLA 2017-11-16 14:46:11 EST
Hi,

In bug 525553 the bug is fixed in version 2.13.9. I still experience the problem though. Does this mean that the gerrit version used by org.eclipce.capra is outdated? 

In bug 525553 the problem seems to occur only when draft changes have been made, but in my case I have no drafts. 

I am reopening the bug because I am still experiencing the issue. 

thanks,

Salome. 
(In reply to Eclipse Webmaster from comment #1)
> This sounds like https://bugs.eclipse.org/bugs/show_bug.cgi?id=525553 .
> 
> I'm going to close this as a dupe, but please reopen if you think it's
> different.
> 
> -M.
> 
> *** This bug has been marked as a duplicate of bug 525553 ***
Comment 3 Jan-Philipp Steghöfer CLA 2017-11-17 04:01:36 EST
Hey,

I am a committer on the same project and am now experiencing similar behaviour. I just pushed changes to a new branch jsteghofer/feature/marker-handler and cannot access them via Gerrit. When I navigate to https://git.eclipse.org/r/111765 I get the message that access is forbidden. Could this have to do something with the branch name? I am able to access Salome's changes.

Best,
Jan-Philipp
Comment 4 Jan-Philipp Steghöfer CLA 2017-11-27 02:37:02 EST
This issue has not been solved for us. We still cannot access the patches we submitted ourselves to a personal feature branch on Gerrit. Here are some steps to reproduce this.

1. Branch an Eclipse project (in our case Eclipse Capra) and create a branch pre-fixed by username (e.g., jsteghofer/feature/test)
2. Make a commit and push it to Gerrit

Expected behaviour: 
a) the change should show up in the dashboard of the submitter (https://git.eclipse.org/r/#/dashboard/self)
b) it is possible to submit new patchsets to update the change by pushing to Gerrit

Actual behaviour:
a) the change does not appear in the dashboard and it's not possible to access the change directly (Error Message: "Code Review - Error
The page you requested was not found, or you do not have permission to view this page.")
b) git denies any pushes that update the change with a permission error
Comment 5 Frederic Gurr CLA 2017-11-28 08:53:42 EST
We noticed that your commit message in https://git.eclipse.org/r/111765 does not contain a change-ID. This could be (part of) the reason why it does not work.

Please try it again with a change-ID in your commit message.
Comment 6 Jan-Philipp Steghöfer CLA 2017-11-28 12:41:53 EST
Hey Frederic,

thank you for responding. Unfortunately, the change-ID in the commit message is not the cause of the problems. Even if the change-ID is contained in the commit to update a patchset (by amending the previous commit and changing the commit message), git rejects the commit because of a permission error.

The other issue that is (I believe) related is that we can't access the changes in Gerrit, also with a permission error. I suspect it has something to do with the fact that we are pushing to user-branches which is AFAIK the preferred way to have feature branches for Eclipse projects.
Comment 7 Frederic Gurr CLA 2017-11-29 05:35:15 EST
Thanks for the feedback.

Does it work for you on non-user-branches and/or other repositories?
Comment 8 Jan-Philipp Steghöfer CLA 2017-11-29 05:54:14 EST
Yes, I can see changes that I pushed to the develop branch and update those changes as well.
Comment 9 Salome Maro CLA 2017-12-06 16:51:15 EST
Hi Frederic,

Do you have any suggestions of how we can solve this issue? As Jan-Philipp mentioned, the problem only occurs on user branches and not our develop branch.
Comment 10 Frederic Gurr CLA 2017-12-07 13:06:04 EST
Currently I'm at a loss here. I will try to look into it next week though.
Comment 11 Mikaël Barbero CLA 2019-08-22 09:00:44 EDT
Do you still face the issue?
Comment 12 Salome Maro CLA 2019-08-30 09:20:50 EDT
We have not had a use case of updating patches to own beaches ever since we started having this problem. We will check and get back if the error still persists. However, we noticed that other people who are not eclipse committers but have an eclipse account and have signed an ECA are not able to create their own user branches. Could this be a related issue? Should non-committers be able to create user branches at all, or is this only possible for the project committers?
Comment 13 Eclipse Webmaster CLA 2019-08-30 13:23:33 EDT
(In reply to Salome Maro from comment #12)
> Should non-committers be able to create user branches at all, or is this only
> possible for the project committers?

Branch creation(either public or in refs/for/$user) should be limited to project committers only.

-M.
Comment 14 Salome Maro CLA 2019-09-10 04:37:31 EDT
I confirm that it is now possible to update one's own patches and this bug no longer exists. Therefore closing the issue.