Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 527299

Summary:	[Aird Editor] Change visibility of some fields or method to avoid code duplication in extensions
Product:	[Modeling] Sirius	Reporter:	Steve Monnier <steve.monnier>
Component:	Core	Assignee:	Steve Monnier <steve.monnier>
Status:	CLOSED FIXED	QA Contact:	Steve Monnier <steve.monnier>
Severity:	enhancement
Priority:	P3	CC:	maxime.porhel, pierre-charles.david
Version:	5.1.0	Keywords:	triaged
Target Milestone:	5.1.1
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/111642 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d750d44f9faa069731501400b52fe6d5d851d71b
Whiteboard:

Description Steve Monnier

2017-11-15 10:54:16 EST

Sirius provides the extension point org.eclipse.sirius.ui.editor.sessionEditorPageProvider in order to extend the behavior of the Overview page of the Aird Editor. To redefine the "New..." and "Add..." button without code duplication a few fields and methods needs to be set as protected.

I do not think this issue requires validation once completed as the Sirius part is technical (visibility change) and the extension itself will be tested in a different issue.

Comment 1 Eclipse Genie

2017-11-15 10:57:52 EST

New Gerrit change created: https://git.eclipse.org/r/111642

Comment 2 Maxime Porhel

2017-11-27 11:11:36 EST

Patch set reviewed and merged. 

Technical issue (visibility change from private ti protected fields).

Comment 3 Eclipse Genie

2017-11-27 14:04:40 EST

Gerrit change https://git.eclipse.org/r/111642 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d750d44f9faa069731501400b52fe6d5d851d71b

Comment 4 Pierre-Charles David

2018-02-01 03:25:41 EST

Available in Sirius 5.1.1. See https://wiki.eclipse.org/Sirius/5.1.1 for details.