Bug 526798

Description Martin Rust 2017-11-03 05:48:44 EDT

The toString() output with the option "Limit number of items in arrays/collections/maps()" does not give a clue to the reader if the limit was exactly reached or if it was overstepped.
E. g. with a limit of 10, the output of a list containing consecutive Integer from 1 to 20 would be indistinguishable from a list containing only those from 1 to 10.

To generate an output of 
"[1, 2, 3, 4, 5, 6, 7, 8, 9, 10, ...]",
I suggest making this simple change to the generated helper method:

private static String toString(Collection<?> collection, int maxLen) {
	StringBuilder builder = new StringBuilder();
	builder.append("[");
	int i = 0;
	Iterator<?> iterator = collection.iterator();
	while (iterator.hasNext() && i < maxLen) {
		if (i > 0) {
			builder.append(", ");
		}
		builder.append(iterator.next());
		i++;
	}
	if (iterator.hasNext()) {
		builder.append(", ...");
	}
	builder.append("]");
	return builder.toString();
}

Note that IMHO the helper method also should be made static.