Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 526355

Summary: [CodeEditWidget] Filename is not configurable
Product: [ECD] Orion Reporter: Sebastian Pahnke <pahnke.sebastian>
Component: EditorAssignee: Sebastian Pahnke <pahnke.sebastian>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: Michael_Rennie
Version: unspecified   
Target Milestone: 17.0   
Hardware: PC   
OS: Windows NT   
See Also: https://github.com/eclipse/orion.client/pull/240
Whiteboard:
Attachments:
Description Flags
Hard coded file name
none
Configured file name none

Description Sebastian Pahnke CLA 2017-10-23 02:34:57 EDT
Created attachment 271139 [details]
Hard coded file name

If you have multiple code edit widgets on one page they share a virtual file system. This is pretty useful if the source codes are connected because in the first editor you can get content assist for variables declared in the second editor (in my case one source code exports stuff which the other then uses).

However, the virtual file name of each editor is hardcoded to "foo.js" which is not very pretty to look at (see attachment). It should be made configurable.
Comment 1 Eclipse Genie CLA 2017-10-23 02:44:45 EDT
GitHub Pull Request 240 created by [spahnke]
https://github.com/eclipse/orion.client/pull/240
Comment 2 Sebastian Pahnke CLA 2017-10-23 02:46:11 EDT
Created attachment 271140 [details]
Configured file name
Comment 3 Michael Rennie CLA 2017-12-05 09:16:34 EST
Merged. Thanks Sebastian!