Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 526297

Summary: [GTK3] [Dark theme] Sometimes the dialogs have white background with dark themes
Product: [Eclipse Project] Platform Reporter: Luis Fernando Planella Gonzalez <lfpg.dev>
Component: SWTAssignee: Platform-SWT-Inbox <platform-swt-inbox>
Status: CLOSED WORKSFORME QA Contact:
Severity: normal    
Priority: P3 CC: ericwill, robert.munteanu
Version: 4.7.1aKeywords: triaged
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard: Category:theme
Attachments:
Description Flags
Screenshot of the preferences window
none
Project properties window
none
Eclipse configuration
none
Updates available window with background theming
none
Screenshot with the Adapta Nokto theme, presenting the bug none

Description Luis Fernando Planella Gonzalez CLA 2017-10-20 05:54:05 EDT
Created attachment 271108 [details]
Screenshot of the preferences window

I'm on Linux, using the Arc Dark theme.
Sometimes all dialogs, such as preferences, project properties, etc, have white background. See the attached screenshots.
If it is the case, all dialogs will be shown that way until restarting Eclipse, which generally fixes the problem and works as a workaround.

I'm using the Jeeeyul theme to match Arc dark, but such dialogs use native SWT, not the custom theme.
Comment 1 Luis Fernando Planella Gonzalez CLA 2017-10-20 05:54:36 EDT
Created attachment 271109 [details]
Project properties window
Comment 2 Eric Williams CLA 2017-10-20 05:57:49 EDT
Which version of Eclipse is this issue occurring in? Also what GTK version is being used?
Comment 3 Luis Fernando Planella Gonzalez CLA 2017-10-20 06:02:47 EDT
Created attachment 271110 [details]
Eclipse configuration
Comment 4 Luis Fernando Planella Gonzalez CLA 2017-10-20 06:03:39 EDT
I've attached the configuration.
In short, the versions are:
* Eclipse: 4.7.1.M20171009-0410
* GTK: 3.22.24
Comment 5 Eric Williams CLA 2017-10-20 06:18:47 EDT
Does the issue occur with the default GTK theme (Adwaita)?
Comment 6 Luis Fernando Planella Gonzalez CLA 2017-10-20 06:29:10 EDT
Actually, the displayed background color when the issue occurs is #e8e8e7, the exact color on Adwaita theme.
Seems like some error occurred when getting the theme color palette and a hardcoded fallback to Adwaita was used.
Oh, by the way I first noticed this issue in Eclipse 4.6, so is not new to 4.7.
Comment 7 Eric Williams CLA 2017-10-20 06:35:10 EDT
(In reply to Luis Fernando Planella Gonzalez from comment #6)
> Actually, the displayed background color when the issue occurs is #e8e8e7,
> the exact color on Adwaita theme.
> Seems like some error occurred when getting the theme color palette and a
> hardcoded fallback to Adwaita was used.
> Oh, by the way I first noticed this issue in Eclipse 4.6, so is not new to
> 4.7.

Interesting, would you be able to upload a zip/tar archive of the theme you are using? This makes debugging the issue a lot easier.
Comment 8 Luis Fernando Planella Gonzalez CLA 2017-10-20 11:47:43 EDT
I'm using the stock Arc Dark theme from https://github.com/horst3180/arc-theme
There you'll find downloads for most distributions.
Comment 9 Robert Munteanu CLA 2018-02-22 06:09:33 EST
I am seeing this as well, with the update notification dialog - it almost always pops up in light colors ( Photon M5, Gnome Shell 3.26.2, Adwaita theme + global dark preference enabled ).
Comment 10 Robert Munteanu CLA 2018-02-22 09:34:14 EST
Created attachment 272820 [details]
Updates available window with background theming
Comment 11 Eric Williams CLA 2018-03-02 12:07:13 EST
I installed the Arc (dark) theme and I cannot reproduce the issue.

For reference: you can use ControlExample to verify whether SWT is picking up the right system colors from your theme. Just look under the "Color" tab, all the system colors will be there.
Comment 12 Luis Fernando Planella Gonzalez CLA 2018-04-10 22:02:06 EDT
Created attachment 273521 [details]
Screenshot with the Adapta Nokto theme, presenting the bug

Somehow the Arc Dark theme seems nowadays less prone to this bug.
But with other dark themes, such as Adapta Nokto (https://github.com/adapta-project/adapta-gtk-theme), almost always this happens.
I'm attaching a screenshot of with that theme.
I've disabled theming in General > Appearance, so I can get a pure GTK theme.
The background around the preferences tree, the left pane and the git staging view show the effect.
Comment 13 Eric Williams CLA 2018-08-23 15:48:54 EDT
(In reply to Luis Fernando Planella Gonzalez from comment #12)
> Created attachment 273521 [details]
> Screenshot with the Adapta Nokto theme, presenting the bug
> 
> Somehow the Arc Dark theme seems nowadays less prone to this bug.
> But with other dark themes, such as Adapta Nokto
> (https://github.com/adapta-project/adapta-gtk-theme), almost always this
> happens.
> I'm attaching a screenshot of with that theme.
> I've disabled theming in General > Appearance, so I can get a pure GTK theme.
> The background around the preferences tree, the left pane and the git
> staging view show the effect.

Is this still reproducible? There were some fixes for this in 4.8, please try with either 4.8 or 4.9 M2.
Comment 14 Eric Williams CLA 2018-10-19 08:43:23 EDT
No response in awhile, please reopen if you experience the issue on 4.9 or a 4.10 I-build.