Bugzilla – Full Text Bug Listing
| Summary: | ExternalFoldersManager.createLinkFolder is not 'synchronized' | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Ed Willink <ed> |
| Component: | Core | Assignee: | Andrey Loskutov <loskutov> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | error-reports-inbox, loskutov |
| Version: | 3.8.2 | ||
| Target Milestone: | 4.8 M4 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=527776 https://bugs.eclipse.org/bugs/show_bug.cgi?id=527819 https://git.eclipse.org/r/112314 https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=13eb6669806171ab554d7a112e84deacfa14d6e9 |
||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 527776 | ||
|
Description
Ed Willink
We observe same issue in our tests, randomly we get this: !ENTRY EWC.TEST 1 0 2017-11-26 04:06:09.516 !MESSAGE Job (Update Installed JREs class org.eclipse.jdt.internal.launching.LaunchingPlugin$JREUpdateJob) during test testReceiveDifferentNotifications encountered resource exception !ENTRY org.eclipse.core.resources 4 374 2017-11-26 04:06:09.516 !MESSAGE Resource '/.org.eclipse.jdt.core.external.folders' already exists. !STACK 0 java.lang.Exception: Resource '/.org.eclipse.jdt.core.external.folders' already exists. at org.eclipse.core.internal.resources.ResourceException.provideStackTrace(ResourceException.java:39) at org.eclipse.core.internal.resources.ResourceException.<init>(ResourceException.java:35) at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:314) at org.eclipse.core.internal.resources.Resource.checkDoesNotExist(Resource.java:301) at org.eclipse.core.internal.resources.Project.assertCreateRequirements(Project.java:52) at org.eclipse.core.internal.resources.Project.create(Project.java:263) at org.eclipse.jdt.internal.core.ExternalFoldersManager.createExternalFoldersProject(ExternalFoldersManager.java:320) at org.eclipse.jdt.internal.core.ExternalFoldersManager.createExternalFoldersProject(ExternalFoldersManager.java:262) at org.eclipse.jdt.internal.core.ExternalFoldersManager.createLinkFolder(ExternalFoldersManager.java:168) at org.eclipse.jdt.internal.core.ExternalFolderChange.updateExternalFoldersIfNecessary(ExternalFolderChange.java:49) at org.eclipse.jdt.internal.core.ChangeClasspathOperation.classpathChanged(ChangeClasspathOperation.java:59) at org.eclipse.jdt.internal.core.SetContainerOperation.executeOperation(SetContainerOperation.java:111) at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:724) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2240) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2267) at org.eclipse.jdt.internal.core.JavaModelOperation.runOperation(JavaModelOperation.java:795) at org.eclipse.jdt.core.JavaCore.setClasspathContainer(JavaCore.java:5679) at org.eclipse.jdt.internal.launching.JREContainerInitializer.initialize(JREContainerInitializer.java:111) at org.eclipse.jdt.internal.launching.LaunchingPlugin$VMChanges.rebind(LaunchingPlugin.java:365) at org.eclipse.jdt.internal.launching.LaunchingPlugin$VMChanges.access$0(LaunchingPlugin.java:299) at org.eclipse.jdt.internal.launching.LaunchingPlugin$VMChanges$1.run(LaunchingPlugin.java:285) at org.eclipse.jdt.internal.core.BatchOperation.executeOperation(BatchOperation.java:39) at org.eclipse.jdt.internal.core.JavaModelOperation.run(JavaModelOperation.java:724) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2240) at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2267) at org.eclipse.jdt.core.JavaCore.run(JavaCore.java:5609) at org.eclipse.jdt.internal.launching.LaunchingPlugin$VMChanges.doit(LaunchingPlugin.java:289) at org.eclipse.jdt.internal.launching.LaunchingPlugin$JREUpdateJob.run(LaunchingPlugin.java:386) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:56) *** Bug 467364 has been marked as a duplicate of this bug. *** (In reply to Andrey Loskutov from comment #1) > We observe same issue in our tests, randomly we get this: > !ENTRY org.eclipse.core.resources 4 374 2017-11-26 04:06:09.516 > !MESSAGE Resource '/.org.eclipse.jdt.core.external.folders' already exists. > !STACK 0 > java.lang.Exception: Resource '/.org.eclipse.jdt.core.external.folders' > already exists. Oops, looking into the code this is a bit different. Current bug is about linked folders *inside* the external folders project. Our issue is the project itself. Looking at the code, the fiddling with linked folders is really not nice, and I don't think I can fix it in the time I have now, so I give the bug back to the team. For the comment 1 issue I've created bug 527776, which is easier to fix :-). Gerrit seem to not post comments on new patches since the bugzilla upgrade, so here is the link to the patch: https://git.eclipse.org/r/112314 Assigning to me because I can't see this misery anymore. Gerrit change https://git.eclipse.org/r/112314 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=13eb6669806171ab554d7a112e84deacfa14d6e9 Aeri problem: https://dev.eclipse.org/recommenders/committers/aeri/v2/#!/problems/55ce3600e4b07ee9504fc54f Aeri problem: https://dev.eclipse.org/recommenders/committers/aeri/v2/#!/problems/55ce3600e4b07ee9504fc54f Verified for 4.8M4 (by inspection) |