Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 525959

Summary:	some OpenJ9 committers can't merge PRs
Product:	Community	Reporter:	Mark Stoodley <mstoodle>
Component:	GitHub	Assignee:	Eclipse Webmaster <webmaster>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	fjeremic, frederic.gurr, joransiu, mpirvu, zlwang
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Mark Stoodley

2017-10-12 16:00:51 EDT

Several Eclipse OpenJ9 committers have reported that they cannot merge pull requests at https://github.com/eclipse/openj9 family of repositories. The list I have so far is:
   GitHub: mpirvu   (mpirvu@ca.ibm.com)
   GitHub: fjeremic (fjeremic@ca.ibm.com)
   GitHub: joransiu (joransiu@ca.ibm.com)

Is there anything wrong at the Eclipse/GitHub end that could be causing it?

Comment 1 Julian Wang

2017-10-12 16:51:03 EDT

me too:
    GitHub: zl-wang (zlwang@ca.ibm.com)

Comment 2 Frederic Gurr

2017-10-13 06:12:16 EDT

The mentioned users are not (yet?) part of the eclipse-open9 team on GitHub.

User fjeremic has a pending invitation, so he should be good to go, once he accepts it.

Comment 3 Filip Jeremic

2017-10-13 10:29:08 EDT

Thanks! Missed this email. I see the merge button after accepting the invitation now.

Comment 4 Mark Stoodley

2017-10-13 17:17:57 EDT

Given all of these users were identified as committers in the initial project creation documentation, shouldn't they all have invitations from the eclipse/openj9 team? I think that's something only the organization admins can do?

Comment 5 Frederic Gurr

2017-10-16 03:45:26 EDT

Did the missing users specify their GitHub ID in their Eclipse account/profile?

Comment 6 mpirvuca.ibm.com Pirvu

2017-10-16 09:25:18 EDT

Indeed, I did not have the GitHub ID in my Eclipse profile. It's the same as my eclipse username: mpirvu
Now that I fixed this, is there anything else I need to do to receive an invitation?
Thanks!

Comment 7 mpirvuca.ibm.com Pirvu

2017-10-16 09:41:53 EDT

It's all good for me now. Thanks!

Comment 8 Joran Siu

2017-10-18 14:03:47 EDT

I've just added my GitHub ID (joransiu) to my account profile.   Can I get an invite to the GitHub group?  Thanks!

Comment 9 Joran Siu

2017-10-18 15:50:48 EDT

I have access now. Many thanks!

Comment 10 Mark Stoodley

2017-10-18 15:52:25 EDT

Ok, that's everyone now that I'm aware of. Thanks for helping to get everyone onboard!