Bugzilla – Full Text Bug Listing
|
Description
Lionel Odolant
New Gerrit change created: https://git.eclipse.org/r/109925 New Gerrit change created: https://git.eclipse.org/r/109924 reproducible on Sirius 5.1 First issue: the tool in "active by default" transient layer are not displayed in the palette Second issue: when activating a optional layer containing tools, the palette is not update. Two quick commits have been done to fix each issue. Nevertheless, they have to be verified and junit test case are needed. So, for now, we have not defined the version of sirius, this fix will be integrated in. It looks like a rather bad regression, so moving this to 5.1.0. Steps to reproduce on Sirius 4.1.7: * Import testTransientLayer project (from testTransientLayer.zip, project created with Sirius 4.1.7) * Open diagram "newDiagram" * --> OK: By default, the tool sections "TransientOptionalSection" (layer "TransientOptional") and "TransientRequiredSection" (layer "TransientRequired") are visible by default. * Activate layer "Workaround" * --> OK: tool section "WorkaroundSection" appears in the palette * Save * Close the diagram * Open the diagram * --> OK: The 3 tool sections are enabled. Steps to reproduce on Sirius 5.1.0: * Import testTransientLayer project (from testTransientLayer.zip, project created with Sirius 4.1.7) * Open diagram "newDiagram" * --> KO: By default, there is no tool section visible. For tool section "TransientOptionalSection" (layer "TransientOptional"), it is expected (see an extract of the documentation extract below). But for tool section "TransientRequiredSection" (layer "TransientRequired"), it should be enabled by default at diagram opening * Activate layer "Workaround" * --> OK: tool section "WorkaroundSection" appears in the palette * Activate layer "TransientOptional" * --> KO: tool section "TransientOptionalSection" does appears in the palette * Save * Close the diagram * Open the diagram * --> KO: There is only "WorkaroundSection" in the palette. "TransientRequiredSection" should also be visible. It is expected to not have "TransientOptionalSection" in the palette. Extract of release notes: "The notion of transient layer has been introduced in Sirius 5.0. (Refer to Sirius Specifier and Sirius User documentation in Diagram chapter). A transient layer is an additional layer containing only decorations or tools. If you have such layer in your VSM, users may encounter some unexpected behaviors. If the layer is not active by default then it will not be applied when opening your diagram even if it was activated before. If the layer is active by default then it will be automatically applied when opening your diagram. We consider this behavior as a known limitation and an enhancement may be done in a further release. In the meantime, there is a workaround which consists to add a fake mapping (that is any mapping with its fields empty) so that the layer will not be considered as transient." Contrary to what has been exchanged with Lionel, even if there are two bugs (see steps to reproduce above or see comment 3 of Laurent F.), the workaround is OK. Created attachment 271166 [details]
testTransientLayer.zip
New Gerrit change created: https://git.eclipse.org/r/110611 New Gerrit change created: https://git.eclipse.org/r/110637 List of scenario to validate: Steps 1 to validate for "pallete content problem": * Import testTransientLayer project (from testTransientLayer.zip, project created with Sirius 4.1.7) * Open diagram "newDiagram" * --> Tool section "TransientRequiredSection" must be displayed as layer "TransientRequired" should be enabled by default at diagram opening. * Activate layer "Workaround" * --> Tool section "WorkaroundSection" appears in the palette * Activate layer "TransientOptional" * --> Tool section "TransientOptionalSection" appears in the palette * Save * Close the diagram * Open the diagram * --> The 3 tool sections are visible in the palette. * Close the diagram and the session. * Open the session * Open the diagram * --> The tool section "TransientOptionalSection" is not visible in the palette (as its activation state is not persisted). The 2 other tool sections are visible. Steps 2 to validate for "pallete content problem": * Import testTransientLayer project (from testTransientLayerWithAllLayerEnabled.zip, project created with Sirius 4.1.7) * Open diagram "newDiagram" * --> Tool sections "TransientRequiredSection" and "WorkaroundSection" must be displayed. The enabled layer "TransientOptional" of version Sirius 4.1.7, containing tool section "TransientOptionalSection" is "converted" as transient layer during the migration. And so it is not enabled. Steps to validate for "Contextual menu provided by tool sections of VSM": * Import testTransientLayer project (from testTransientLayer.zip, project created with Sirius 4.1.7) * Open diagram "newDiagram" * Open contextual menu on the diagram * --> You should not see the action "PopupMenuInTransientOptionalLayer/ActionInTransientOptionalLayer" * Activate the layer "TransientOptional" * --> You should see the action "PopupMenuInTransientOptionalLayer/ActionInTransientOptionalLayer" * Activate the layer "TransientOptional" * --> You should not see the action "PopupMenuInTransientOptionalLayer/ActionInTransientOptionalLayer" Steps to validate for "Label of ChangeLayerActivation (visible in Undo/Redo menu)": * Import testTransientLayer project (from testTransientLayer.zip, project created with Sirius 4.1.7) * Open diagram "newDiagram" * Activate layer "Workaround" * --> The undo menu (menu Edit/Undo...") label is "Undo Show "Workaround" layer" * Activate layer "TransientOptional" * --> The undo menu (menu Edit/Undo...") label is "Undo Show "TransientOptional" layer" Steps to validate for "Drop tool": * Import testTransientLayer project (from testTransientLayer.zip, project created with Sirius 4.1.7) * Open diagram "newDiagram" * Activate layer "TransientOptional" * Drag'n'drop "C1" from ModelExplorer view to the diagram * --> A blue node C1 is added in the diagram. Steps to validate for "Detection of target for paste tool": * Import testTransientLayer project (from testTransientLayer.zip, project created with Sirius 4.1.7) * Open diagram "newDiagram" * Activate layer "TransientOptional" * Drag'n'drop "C1" from ModelExplorer view to the diagram * --> A blue node C1 is added in the diagram. * Use "Copy" contextual menu on node "C1" * use "Paste" contextual menu on diagram * --> A new blue node Copy is added in the diagram (the corresponding semantic class Copy is added in package test). Steps to validate for "Update of an existing diagram using a newly activated diagram extension" * Import testTransientLayer project (from testTransientLayer.zip, project created with Sirius 4.1.7) * Open diagram "newDiagram" * --> Tool section "TransientRequiredSection" must be displayed * Activate viewpoint "testTransientViewpoint2" * --> A new tool section named "TransientRequiredSection2" is now visible. Steps to validate for "Check decorator on Layers icon of tabbar after transient layer activation": * Import testTransientLayer project (from testTransientLayer.zip, project created with Sirius 4.1.7) * Open diagram "newDiagram" * Activate layer "TransientOptional" * --> The icon for Layers in tabbar is changed (a check decorator is added in the bottom right corner) Created attachment 271191 [details]
testTransientLayer.zip
Created attachment 271192 [details]
testTransientLayerWithAllLayersEnabled.zip
Gerrit change https://git.eclipse.org/r/110637 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e87d74adc9adc58c72504e1989124b7445680bba Gerrit change https://git.eclipse.org/r/110611 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=812c25564d28ca486f73d5e0ca7a4b2714822148 Gerrit change https://git.eclipse.org/r/109924 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a4e0636395b159e7dd2fa6c8a8d2c727f2a2eff1 Gerrit change https://git.eclipse.org/r/109925 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=506aa8f3fdabb04ad31c8a783abbd388c5714798 Validated on Sirius 5.1.0 rc4 Note: typo in third scenario the second "* Activate the layer "TransientOptional" " instruction should be 'Disable the layer...' Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0. New Gerrit change created: https://git.eclipse.org/r/111305 Gerrit change https://git.eclipse.org/r/111305 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=641c44b9275f78ce9ed31b72fabe0bdf44ff100e New Gerrit change created: https://git.eclipse.org/r/112938 Gerrit change https://git.eclipse.org/r/112938 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=9a042693b965e5db6aa31dea04aa3a2dc6245195 New Gerrit change created: https://git.eclipse.org/r/113131 Gerrit change https://git.eclipse.org/r/113131 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3fc51ef58507803d759b21668b1a824729b3b01f |