Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 525821

Summary:	Membership page shows 2 year old versions of marketplace connectors, instead of latest
Product:	Community	Reporter:	Nick Boldt <nboldt>
Component:	Marketplace	Assignee:	Marketplace Inbox <marketplace-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	chris.guindon, eric.poirier
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/106531 https://git.eclipse.org/c/www.eclipse.org/eclipse.org-common.git/commit/?id=567b4a171441cc9a9d8297167e45e4395350746b
Whiteboard:

Description Nick Boldt

2017-10-10 09:57:13 EDT

On the membership page for Red Hat [0], there are two entries listed for Red Hat JBoss Developer Studio [1] and Integration Stack [2]

[0] https://www.eclipse.org/membership/showMember.php?member_id=731 

[1] https://marketplace.eclipse.org/node/1616973

[2] https://marketplace.eclipse.org/node/2872800

Yet the VERSIONS shown are not the latest, but 2 versions behind the latest (9.x for Eclipse 4.5 instead of 11.x for Eclipse 4.7). 

When I drag the [INSTALL] buttons from the above marketplace pages into Eclipse 4.7, devstudio 11 and devstudio-is 11 are offered to be installed.

So it seems there's a bug either in the marketplace (in that the latest version is not the first / index version in the database) or on the membership page (perhaps the versions are retrieved as a hash, but not sorted to retrieve the most recent one?)

If someone can point me to the code that provides either the marketplace listing or the membership page, I'll happily attempt to contribute a patch to fix this.

Comment 1 Christopher Guindon

2017-10-10 10:20:45 EDT

(In reply to Nick Boldt from comment #0)

> 
> So it seems there's a bug either in the marketplace (in that the latest
> version is not the first / index version in the database) or on the
> membership page (perhaps the versions are retrieved as a hash, but not
> sorted to retrieve the most recent one?)

I think the issue is on showMember.php.

We probably forgot to update this page after we implemented solution versions for marketplace listings.

This page is probably using the old version field instead of the latest solution version field.


> 
> If someone can point me to the code that provides either the marketplace
> listing or the membership page, I'll happily attempt to contribute a patch
> to fix this.

The code for the membership pages is available here:
https://git.eclipse.org/c/www.eclipse.org/membership.git/tree/showMember.php

But our Drupal code is not available publicly. 

I will ask Eric to take a look at this issue this week.

Comment 2 Eclipse Genie

2017-10-10 14:12:19 EDT

New Gerrit change created: https://git.eclipse.org/r/106531

Comment 3 Eclipse Genie

2017-10-11 11:43:27 EDT

Gerrit change https://git.eclipse.org/r/106531 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse.org-common.git/commit/?id=567b4a171441cc9a9d8297167e45e4395350746b

Comment 4 Christopher Guindon

2017-10-11 11:46:39 EDT

(In reply to Eclipse Genie from comment #3)
> Gerrit change https://git.eclipse.org/r/106531 was merged to [master].
> Commit:
> http://git.eclipse.org/c/www.eclipse.org/eclipse.org-common.git/commit/
> ?id=567b4a171441cc9a9d8297167e45e4395350746b

It's possible to have multiple versions for a listing, should we consider removing the version in the marketplace listing section of showMember.php page?

Comment 5 Christopher Guindon

2017-10-23 11:40:48 EDT

(In reply to Christopher Guindon from comment #4)
> (In reply to Eclipse Genie from comment #3)
> > Gerrit change https://git.eclipse.org/r/106531 was merged to [master].
> > Commit:
> > http://git.eclipse.org/c/www.eclipse.org/eclipse.org-common.git/commit/
> > ?id=567b4a171441cc9a9d8297167e45e4395350746b
> 
> It's possible to have multiple versions for a listing, should we consider
> removing the version in the marketplace listing section of showMember.php
> page?

I assume this not a problem since there was no reply.

Nick feel free to comment if you don't think this fix works for you!

Closing this bug!

Comment 6 Nick Boldt

2017-10-31 12:11:57 EDT

Thanks for the fix - looks good now.

Just out of curiosity, what's the sort order here? 

It'd be nice to be sorted by most recently updated first, so that ancient Hibernate connectors are listed after the new devstudio and jbosstools stuff.

I can open a new BZ if you'd like, or I could reopen this one. 

Just thought I'd ask here first to see if this is something you'd be willing to add, or if I'm asking for tiny irrelevant tweaks that would benefit only me. :D

Comment 7 Eric Poirier

2017-11-29 11:46:04 EST

(In reply to Nick Boldt from comment #6)
> Thanks for the fix - looks good now.
> 
> Just out of curiosity, what's the sort order here? 
> 
> It'd be nice to be sorted by most recently updated first, so that ancient
> Hibernate connectors are listed after the new devstudio and jbosstools stuff.
> 
> I can open a new BZ if you'd like, or I could reopen this one. 
> 
> Just thought I'd ask here first to see if this is something you'd be willing
> to add, or if I'm asking for tiny irrelevant tweaks that would benefit only
> me. :D

Hi Nick,

The listings are currently ordered by creation date. I think it would be a good improvement to have to most recent listings at first.

I think you can create a new bug since its out of the scope of this current bug.

Let me know if you have more questions.

Thanks!