Bugzilla – Full Text Bug Listing
| Summary: | [9] Warn when consuming auto modules with unstable names | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Stephan Herrmann <stephan.herrmann> |
| Component: | Core | Assignee: | Stephan Herrmann <stephan.herrmann> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | daniel_megert, jarthana, manoj.palat, register.eclipse, sasikanth.bharadwaj |
| Version: | 4.7.1 | ||
| Target Milestone: | 4.8 M7 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/117598 https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=ab20dcc315da3b88242cf9c4ff39323b4a718aa0 |
||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 534473 | ||
|
Description
Stephan Herrmann
Would be important sooner (while people start working with auto modules) rather than later (when all are explicit modules). New Gerrit change created: https://git.eclipse.org/r/117598 (In reply to Eclipse Genie from comment #2) > New Gerrit change created: https://git.eclipse.org/r/117598 Implemented the new warning. A few things to callout in that patch (comments welcome!): - determine whether auto-name is derived from manifest or file name directly when using AutomaticModuleNaming, I hope I didn't break anything (wasn't 100% about the role of parameter 'skipDirectory'). - new message reads Name of automatic module ''{0}'' is unstable, it is derived from the module's file name. - made this warning configurable via JavaCore.COMPILER_PB_UNSTABLE_AUTO_MODULE_NAME (new API) - needed a way to suppress / configure from CLI => followed the example of javac and introduced warning token "module" - added @SW support to modules Gerrit change https://git.eclipse.org/r/117598 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=ab20dcc315da3b88242cf9c4ff39323b4a718aa0 (In reply to Eclipse Genie from comment #4) > Gerrit change https://git.eclipse.org/r/117598 was merged to [master]. > Commit: > http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/ > ?id=ab20dcc315da3b88242cf9c4ff39323b4a718aa0 Released for 4.8 M6 Still happy to accept comments (e.g., re javadoc, message text etc.). Verified for 4.8 M6 with build I20180308-0630 There is no UI for this. I think this is wrong. Please provide a Gerrit change that adds this to the UI. (In reply to Dani Megert from comment #7) > There is no UI for this. I think this is wrong. Please provide a Gerrit > change that adds this to the UI. Any suggestions what the label should read? The token for CLI and @SW is "module", modeled after javac. From them all we know is: "module — Warns about the module system-related issues." [1] Similarly, ecj --help has this: module + module related problems. On the preference page we already have a heading "Modules", so below that heading we probably want to be more specific, right? The JavaCore constant says: "Reporting when a module requires an auto module with an unstable name" So perhaps the UI should say: "An automatic module with an unstable name is required: [E/W/I/I]" ? [1] https://docs.oracle.com/javase/9/tools/javac.htm (In reply to Stephan Herrmann from comment #8) > So perhaps the UI should say: > > "An automatic module with an unstable name is required: [E/W/I/I]" > > ? I'd be fine with that. I'm also fine doing this in 4.9 as long as we have a bug report that covers the UI work. (In reply to Dani Megert from comment #9) > (In reply to Stephan Herrmann from comment #8) > > So perhaps the UI should say: > > > > "An automatic module with an unstable name is required: [E/W/I/I]" > > > > ? > > I'd be fine with that. I'm also fine doing this in 4.9 as long as we have a > bug report that covers the UI work. Ran out of time, so here is bug 534473. Reclosing the core part. Moving back to verified. |