Bugzilla – Full Text Bug Listing
| Summary: | [10.13] TextLayout with embedded images is missing text on macOS High Sierra | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Peter Severin <peter> | ||||||
| Component: | SWT | Assignee: | Lakshmi P Shanmugam <lshanmug> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | critical | ||||||||
| Priority: | P3 | CC: | baza, lpvoisin, lshanmug, picard, register.eclipse, sravankumarl | ||||||
| Version: | 4.7.1 | Flags: | sravankumarl:
review+
|
||||||
| Target Milestone: | 4.7.2 | ||||||||
| Hardware: | Macintosh | ||||||||
| OS: | Mac OS X | ||||||||
| See Also: |
https://git.eclipse.org/r/111535 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9efbe4a8235bbb98fd1e36720eea53d0f012e240 https://git.eclipse.org/r/111623 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c3e3b10064d80fba27e34154f06a6ca0e75e381a |
||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 527287 | ||||||||
| Attachments: |
|
||||||||
|
Description
Peter Severin
Created attachment 270786 [details]
Snippet205 on macOS Sierra
I've investigated some more and I see a warning in the console that is most probably related to this issue: ... [SWTTextAttachmentCell attachment]: unrecognized selector sent to instance 0x79... This warning is generated by the call to NSLayoutManager#drawGlyphsForGlyphRange from the TextLayout#draw method. This method translates to the following: OS.objc_msgSend(this.id, OS.sel_drawGlyphsForGlyphRange_atPoint_, glyphsToShow, origin); I hope this helps to identify the issue. Note that this bug also occurs with nightly builds of Eclipse 4.8. Is there anyone who look into this issue? It makes the product I am developing (WireframeSketcher) unusable under macOS High Sierra. Guys, please fix this blocker. I'm able to reproduce the problem and currently investigating it. Setting target to 4.7.2. Lakshmi, do you have any update on this issue? It's rather critical for us. Thanks! Version 4.7.2 is close to be released, but there is no fix for this bug. Is there any chance for it to be fixed? (In reply to Peter Severin from comment #7) > Version 4.7.2 is close to be released, but there is no fix for this bug. Is > there any chance for it to be fixed? I'm currently working on this and plan to fix for 4.7.2. Hi Till, any idea on what has changed in NSTextAttachment/Cell? (In reply to Lakshmi Shanmugam from comment #9) > Hi Till, any idea on what has changed in NSTextAttachment/Cell? See https://developer.apple.com/documentation/appkit/nstextattachmentcellprotocol NSTextAttachmentCellProtocol has this new and required property "attachment" (it seems since since 10.11): https://developer.apple.com/documentation/appkit/nstextattachmentcellprotocol/1508396-attachment New Gerrit change created: https://git.eclipse.org/r/111535 Will this change work on earlier versions of macOS than 10.11? (In reply to Till Brychcy from comment #10) > (In reply to Lakshmi Shanmugam from comment #9) > > Hi Till, any idea on what has changed in NSTextAttachment/Cell? > > See > https://developer.apple.com/documentation/appkit/nstextattachmentcellprotocol > > NSTextAttachmentCellProtocol has this new and required property "attachment" > (it seems since since 10.11): > https://developer.apple.com/documentation/appkit/nstextattachmentcellprotocol/1508396-attachment > Thanks Till! Adding the attachment method to SWTTextAttachmentCell fixes the problem. Looks like providing an implementation for attachment method is not required. (In reply to Peter Severin from comment #12) > Will this change work on earlier versions of macOS than 10.11? I've a updated the gerrit with a simplified patch and added a version check. I've not tested, but this should work with 10.10 as well. Gerrit change https://git.eclipse.org/r/111535 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9efbe4a8235bbb98fd1e36720eea53d0f012e240 Verified the fix on 10.13 & 10.10.5 with I20171115-0115. New Gerrit change created: https://git.eclipse.org/r/111623 Gerrit change https://git.eclipse.org/r/111623 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c3e3b10064d80fba27e34154f06a6ca0e75e381a Thanks for the review, Sravan! Marking as resolved. Verified with Build M20171115-1700 on macOS 10.13.1. Thank you very much for fixing this ugly bug. |