Bug 522671

Description Till Brychcy 2017-09-22 16:31:50 EDT

DESCRIPTION:
Create the following four projects (the same as in bug 522670, but the type annotations are not relevant here and have been removed)

--- project util, 3 files:
module util {
	exports my.util;
}
--
package my.util;
public abstract class AnnotatedInModule {
	abstract public Data getTime();
}
--
package my.util;
public class Data {
}

--- project util2, 2 files:
module util2 {
	exports my.util.nested;
}
--
package my.util.nested;
class Unrelated {
}

--- project other (1 file) with project util on the modulepath:
package a.other;
import my.util.Data;
public class AnnotatedInOtherNonModule {
	Data generationDate;
}

--- project test (1 file)
package test;
import a.other.AnnotatedInOtherNonModule;
import my.util.AnnotatedInModule;
import my.util.Data;
public class Test extends AnnotatedInOtherNonModule {
	public Data f(AnnotatedInModule calendar) {
		return calendar.getTime();
	}
}

Open Test in an editor. Only in the editor, errors are show because the types my.util.AnnotatedInModule and my.util.Data are not found.

ANALYSIS:
The toplevel package "my" is only in the modulebinding and not in the corresponding LookupEnvironment,
so a new PackageBinding instance is created for "my.util" when the types are compiled to which they are added so the types are not found
in the already existing PackageBinding.

PATCH:
Make sure that toplevel packages that are put into ModuleBinding.declaredPackages are always also put into the correspoding LookupEnvironment.knownPackages
This also fixes bug 522327 in a better way to the patch for that code in LookupEnvironment has been reverted.