Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 522614

Summary:	[9][quick fix] Add requires module in module-info.java
Product:	[Eclipse Project] JDT	Reporter:	Noopur Gupta <noopur_gupta>
Component:	UI	Assignee:	Kalyan Prasad Tatavarthi <kalyan_prasad>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert
Version:	4.7
Target Milestone:	4.7.1a
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/105673 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=12ebb8b8b2fd5b09a179d8992a6489b03da62e70 https://git.eclipse.org/r/105707 https://git.eclipse.org/r/105706 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=57f44e263f851314ca7452295b27522108d00430 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=9653e99b7397ac3b5c59b0155a4f90d456dd1240
Whiteboard:
Bug Depends on:	506377
Bug Blocks:

Description Noopur Gupta

2017-09-21 16:07:59 EDT

module test {
	provides java.sql.Driver with C;
}

Here, we have an error at java.sql (java.sql cannot be resolved to a type). The quick fix to add requires should be available on the error.

Comment 1 Eclipse Genie

2017-09-25 03:38:36 EDT

New Gerrit change created: https://git.eclipse.org/r/105673

Comment 2 Eclipse Genie

2017-09-25 08:57:58 EDT

Gerrit change https://git.eclipse.org/r/105673 was merged to [BETA_JAVA9].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=12ebb8b8b2fd5b09a179d8992a6489b03da62e70

Comment 3 Noopur Gupta

2017-09-25 09:03:29 EDT

Thanks, Kalyan. 

I fixed the formatting and a potential null pointer access with:
http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?h=BETA_JAVA9&id=e1e1738ec538fd27f356ff2d62a779f94bb1d056

Please take care of such things in future patches.

Comment 4 Eclipse Genie

2017-09-25 09:06:17 EDT

New Gerrit change created: https://git.eclipse.org/r/105707

Comment 5 Eclipse Genie

2017-09-25 09:06:24 EDT

New Gerrit change created: https://git.eclipse.org/r/105706

Comment 6 Eclipse Genie

2017-09-25 09:07:06 EDT

Gerrit change https://git.eclipse.org/r/105706 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=57f44e263f851314ca7452295b27522108d00430

Comment 7 Eclipse Genie

2017-09-25 09:07:18 EDT

Gerrit change https://git.eclipse.org/r/105707 was merged to [R4_7_maintenance].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=9653e99b7397ac3b5c59b0155a4f90d456dd1240

Comment 8 Noopur Gupta

2017-09-25 09:08:11 EDT

Also released to R4_7_maintenance.