Bugzilla – Full Text Bug Listing
| Summary: | [9] Add test cases for the quick fix provided to add module for unresolved import and type | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Kalyan Prasad Tatavarthi <kalyan_prasad> |
| Component: | UI | Assignee: | Kalyan Prasad Tatavarthi <kalyan_prasad> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, noopur_gupta |
| Version: | 4.7 | ||
| Target Milestone: | 4.7.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/109908 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=f9708a88856889cee563cb34e9df1b23b40f0681 https://git.eclipse.org/r/109987 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=6d10ed6d8d5326d1eafc729588d5037d1081daa8 https://git.eclipse.org/r/110103 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=0a85307d7a13b8aeb80b16e2cb517a30ae9b71f4 https://git.eclipse.org/r/110107 https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=7e86d02b4c47c17af831177a0e88e56316e497ac |
||
| Whiteboard: | |||
| Bug Depends on: | 506377 | ||
| Bug Blocks: | |||
|
Description
Kalyan Prasad Tatavarthi
New Gerrit change created: https://git.eclipse.org/r/109908 Kalyan, please make the changes mentioned on Gerrit. (In reply to Noopur Gupta from comment #2) > Kalyan, please make the changes mentioned on Gerrit. I have made the changes mentioned and updated the Gerrit patch Gerrit change https://git.eclipse.org/r/109908 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=f9708a88856889cee563cb34e9df1b23b40f0681 New Gerrit change created: https://git.eclipse.org/r/109987 (In reply to Eclipse Genie from comment #5) > New Gerrit change created: https://git.eclipse.org/r/109987 (In reply to Kalyan Prasad Tatavarthi from comment #3) > (In reply to Noopur Gupta from comment #2) > > Kalyan, please make the changes mentioned on Gerrit. > > I have made the changes mentioned and updated the Gerrit patch - TODO and e.printStackTrace() was still present in the file. The exception was already being thrown hence try-catch was not required. - #tearDown may cause NPE. Check other places where JavaProjectHelper#delete is called. A null check is required. - I have replaced JavaProjectHelper#delete with JavaProjectHelper#clear. - super.tearDown(); should be present. - A new test class should also be added to the test suite. I have fixed these in the new Gerrit patch. Please have a look and Gerrit change https://git.eclipse.org/r/109987 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=6d10ed6d8d5326d1eafc729588d5037d1081daa8 Released to R4_7 also and increased the bundle version. Replacing JavaProjectHelper#delete with JavaProjectHelper#clear causes the second test testAddModuleRequiresAndImportProposal to fail some times. New Gerrit change created: https://git.eclipse.org/r/110103 In the new Gerrit change JavaProjectHelper#clear is replaced with JavaProjectHelper#delete. This fix makes sure that the tests pass always. Gerrit change https://git.eclipse.org/r/110103 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=0a85307d7a13b8aeb80b16e2cb517a30ae9b71f4 New Gerrit change created: https://git.eclipse.org/r/110107 Gerrit change https://git.eclipse.org/r/110107 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=7e86d02b4c47c17af831177a0e88e56316e497ac Verified in M20171108-1700. |