Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 522230

Summary: Automated Management of Dependencies: Up does not preserve selection
Product: [Eclipse Project] PDE Reporter: Karsten Thoms <karsten.thoms>
Component: UIAssignee: Karsten Thoms <karsten.thoms>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: sja.eclipse, Vikas.Chandra
Version: 4.7   
Target Milestone: 4.8 M3   
Hardware: PC   
OS: Mac OS X   
See Also: https://git.eclipse.org/r/105046
https://git.eclipse.org/r/105752
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=7dab2118c8b75a710c2ae67aa8ea4fd487b92656
Whiteboard:
Attachments:
Description Flags
There is a mark on the initial selection. none

Description Karsten Thoms CLA 2017-09-13 05:15:46 EDT 
When clicking on Up the selection stays on the selected line, but not on the selected element. Thus to move one element several steps up it has to be selected manually multiple times. It is expected that the element stays selected and the selection moves up.

The Down button works as expected.
Comment 1 Karsten Thoms CLA 2017-09-13 05:29:59 EDT 
related class: org.eclipse.pde.internal.ui.editor.plugin.DependencyManagementSection
Comment 2 Eclipse Genie CLA 2017-09-13 05:40:45 EDT 
New Gerrit change created: https://git.eclipse.org/r/105046
Comment 3 Vikas Chandra CLA 2017-09-13 08:40:53 EDT 
Created attachment 270177 [details]
There is a mark on the initial selection.

The main problem is solved. Thanks for that but there is a minor issue pending.
Comment 4 Vikas Chandra CLA 2017-09-13 08:42:30 EDT 
Inspite of that, I strongly recommend a merge for this fix because after this fix, the main problem is solved. Also that mark is there for down button with or without this fix. ( may be a new "minor" bug).
Comment 5 Vikas Chandra CLA 2017-09-13 08:43:09 EDT 
I plan to merge it once 4.8M2 is over. ( end of this week).
Comment 6 Karsten Thoms CLA 2017-09-13 10:12:30 EDT 
> There is a mark on the initial selection.
I don't see such a marker. I'm on macOS, maybe platform dependent. What do you mean by 'initial selection'? When I open the manifest, there is nothing selected initially.
Comment 7 Martin Karpisek CLA 2017-09-14 16:27:57 EDT 
*** Bug 479577 has been marked as a duplicate of this bug. ***
Comment 8 Martin Karpisek CLA 2017-09-17 13:49:46 EDT 
*** Bug 510557 has been marked as a duplicate of this bug. ***
Comment 9 Eclipse Genie CLA 2017-09-26 03:50:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/105752
Comment 11 Vikas Chandra CLA 2017-09-26 03:53:10 EDT 
There was some issues with the 1st gerrit patch. I created duplicate gerrit patch
105752 with  Karsten Thoms as author and committed that patch.

Thanks Karsten !
Comment 12 Vikas Chandra CLA 2017-10-25 05:01:33 EDT 
verified on
Version: Photon (4.8)
Build id: I20171023-2000