Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 522199

Summary: Saving process in ResourceSaveDiagnose should be atomic
Product: [Modeling] Sirius Reporter: Steve Monnier <steve.monnier>
Component: CoreAssignee: Steve Monnier <steve.monnier>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: pierre-charles.david
Version: 5.0.0Keywords: triaged
Target Milestone: 5.0.3   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/104982
https://git.eclipse.org/r/104983
https://git.eclipse.org/r/104988
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8cc9ce0fe1a08659f7313575d73f1ff20c79ba78
https://git.eclipse.org/r/105226
Whiteboard: need_test
Attachments:
Description Flags
ecore_sample_for_validation none

Description Steve Monnier CLA 2017-09-12 10:25:49 EDT
Backport to Sirius branch v5.0.x of Bugzilla 521946
Comment 1 Eclipse Genie CLA 2017-09-12 11:02:10 EDT
New Gerrit change created: https://git.eclipse.org/r/104982
Comment 2 Eclipse Genie CLA 2017-09-12 11:05:15 EDT
New Gerrit change created: https://git.eclipse.org/r/104983
Comment 3 Eclipse Genie CLA 2017-09-12 11:18:03 EDT
New Gerrit change created: https://git.eclipse.org/r/104988
Comment 5 Pierre-Charles David CLA 2017-09-13 05:14:12 EDT
Fixed by 8cc9ce0fe1a08659f7313575d73f1ff20c79ba78, but I'm keeping the ticket open to see if we can create an automated non-regression test.
Comment 6 Steve Monnier CLA 2017-09-14 05:00:02 EDT
Created attachment 270186 [details]
ecore_sample_for_validation
Comment 7 Steve Monnier CLA 2017-09-14 05:05:04 EDT
Validation step:
- 1/ In org.eclipse.sirius.business.internal.session.danalysis.ResourceSaveDiagnose.hasDifferentSerialization(Map<?, ?>) add a Thread.sleep(20000) after resourcetoSave.eSetDeliver(false);
- 2/ Launch a runtime and import the sample in attachments
- 3/ Create a new modeling project
- 4/ Drag and drop the model from the imported project to the new project
- 5/ Activate the Design viewpoint
- 6/ create a new representation
-> Check that you don't have every diagram element stacked on (0,0)
-> Check that you can move diagram elements

If you can't do steps 3 to 6 in 20s, you can increase the value in step1.
Comment 8 Eclipse Genie CLA 2017-09-15 10:53:00 EDT
New Gerrit change created: https://git.eclipse.org/r/105226
Comment 9 Pierre-Charles David CLA 2019-04-16 08:57:10 EDT
Closing all clones created to report fixes on a hypothetical version 5.0.3: there is no plan to actually release that version.