Bug 522152

Description Michael Rennie 2017-09-11 11:35:33 EDT

Running the tests multiple times against the latest from master this morning (against https://github.com/eclipse/orion.client/commit/6ff3bf8541456cdac6abbe8edaf25a23fb46e219)

I ended up getting the following exception:

Unhandled rejection TypeError: Cannot set property 'Properties' of null
    at FsMetastore.<anonymous> (/Users/mrennie/git/orion.client/modules/orionode/lib/metastore/fs/store.js:503:26)
    at /Users/mrennie/git/orion.client/modules/orionode/lib/metastore/fs/store.js:550:6
    at tryCatcher (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/util.js:16:23)
    at Promise.module.exports.Promise._settlePromiseFromHandler (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise.module.exports.Promise._settlePromise (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise.module.exports.Promise._settlePromise0 (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise.module.exports.Promise._settlePromises (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/promise.js:693:18)
    at Promise.module.exports.Promise._fulfill (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/promise.js:638:18)
    at Promise.module.exports.Promise._resolveCallback (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/promise.js:432:57)
    at Promise.module.exports.Promise._settlePromiseFromHandler (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/promise.js:524:17)
    at Promise.module.exports.Promise._settlePromise (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise.module.exports.Promise._settlePromise0 (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise.module.exports.Promise._settlePromises (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/promise.js:689:18)
    at Async._drainQueue (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/async.js:143:10)
    at Immediate.e.Async.drainQueues (/Users/mrennie/git/orion.client/modules/orionode/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:649:20)
    at tryOnImmediate (timers.js:622:5)

Perhaps one of the tearDowns failed to clean out the entire test workspace? Regardless, we should add support in the server is handle a bad metadata read and recover (if thats whats causing this exception).