Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 522108

Summary:

"Line Style" actions are not available if the selection does not contain only edges

Product:

[Modeling] Sirius

Reporter:

Laurent Redor <laurent.redor>

Component:

Diagram

Assignee:

Laurent Redor <laurent.redor>

Status:

CLOSED FIXED

QA Contact:

Julien Dupont <julien.dupont>

Severity:

enhancement

Priority:

CC:

julien.dupont, pierre-charles.david

Version:

1.0.0

Keywords:

triaged

Target Milestone:

5.1.0

Hardware:

All

OS:

All

See Also:

Whiteboard:

Attachments:

Description	Flags
522108SampleProject.zip	none

Description Laurent Redor

2017-09-11 04:07:33 EDT

It will be interesting to allow these actions even if the selection contains other kind of elements (the typical example is the selection of the label of an edge with its edge).

The actions must be available/verified in:
* contextual menu (Format/Line Style)
* tabbar (drow down menu)
* global Eclipse menu (Diagram/Line Style)

Comment 1 Eclipse Genie

2017-09-11 11:11:32 EDT

New Gerrit change created: https://git.eclipse.org/r/104895

Comment 2 Eclipse Genie

2017-09-11 11:11:34 EDT

New Gerrit change created: https://git.eclipse.org/r/104894

Comment 3 Eclipse Genie

2017-09-11 11:11:35 EDT

New Gerrit change created: https://git.eclipse.org/r/104893

Comment 4 Eclipse Genie

2017-09-11 11:11:39 EDT

New Gerrit change created: https://git.eclipse.org/r/104896

Comment 5 Laurent Redor

2017-09-12 04:34:08 EDT

Steps to reproduce/validate:
* Import SampleProject from 522108SampleProject.zip
* Open diagram "new 2330 Diagram"
* Select the edge "toB"
* Actions "Rectilinear Style Routing", "Obllique Style Routing" and "Tree Style Routing" is visible and enabled
  * in tabbar.
  * in contextual menu "Format/Line Style".
  * is visible and enabled in global Eclipse menu "Diagram/Line Style".
* Select the edge "toB" and the label "toB" of this edge
* Actions "Rectilinear Style Routing", "Obllique Style Routing" and "Tree Style Routing" is visible and enabled
  * in tabbar.
  * in contextual menu "Format/Line Style".
  * is visible and enabled in global Eclipse menu "Diagram/Line Style".
* Select the edges "toB", "toA", the green border node and the container p4.
* Actions "Rectilinear Style Routing", "Obllique Style Routing" and "Tree Style Routing" is visible and enabled
  * in tabbar.
  * in contextual menu "Format/Line Style".
  * is visible and enabled in global Eclipse menu "Diagram/Line Style".

Comment 6 Laurent Redor

2017-09-12 04:34:40 EDT

Created attachment 270163 [details]
522108SampleProject.zip

Comment 7 Eclipse Genie

2017-09-12 05:36:15 EDT

New Gerrit change created: https://git.eclipse.org/r/104931

Comment 8 Eclipse Genie

2017-09-14 03:59:42 EDT

Gerrit change https://git.eclipse.org/r/104896 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3b565d7e79273f0504738a5d7e659d84ba785318

Comment 9 Eclipse Genie

2017-09-14 03:59:43 EDT

Gerrit change https://git.eclipse.org/r/104895 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=138c1b6955a0fc16e22d8da8cc04053de52a772c

Comment 10 Eclipse Genie

2017-09-14 03:59:44 EDT

Gerrit change https://git.eclipse.org/r/104894 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ff06701e4ee887fcab87f39f70c7970096149e21

Comment 11 Eclipse Genie

2017-09-14 03:59:45 EDT

Gerrit change https://git.eclipse.org/r/104893 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1047f8248cd09faa67c268a8dd20e0b6dafe511b

Comment 12 Eclipse Genie

2017-09-14 03:59:46 EDT

Gerrit change https://git.eclipse.org/r/104931 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1f428296280aa12bf90966b1dc246935c218a0fb

Comment 13 Pierre-Charles David

2017-11-08 03:37:04 EST

Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.