Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 522007

Summary: "Hide label" action is not available if the selection contains an edge without label
Product: [Modeling] Sirius Reporter: Laurent Redor <laurent.redor>
Component: DiagramAssignee: Laurent Redor <laurent.redor>
Status: CLOSED FIXED QA Contact: Julien Dupont <julien.dupont>
Severity: enhancement    
Priority: P3 CC: julien.dupont, pierre-charles.david
Version: 4.1.0Keywords: triaged
Target Milestone: 5.1.0   
Hardware: PC   
OS: Windows NT   
See Also: https://git.eclipse.org/r/104671
https://git.eclipse.org/r/104668
https://git.eclipse.org/r/104723
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a5ec902ef53717bf1cebe9d4beb9a7f80b4dc783
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=800d5cb892245801ff00f8423e3c248d67c123cd
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=bd1d82c356db9ada41d4bbe29b128ce912149349
https://git.eclipse.org/r/105685
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8f273830cab321d372d4e832d212b044896d8178
Whiteboard:
Attachments:
Description Flags
Sample project to reproduce the issue none

Description Laurent Redor CLA 2017-09-07 12:10:45 EDT 
The goal of this bug is to authorized the action "Hide label" even if the selection contains an edge without label.
Currently, the action is available only if all elements in the selection have a label to hide.

It will be the same for the action "Show label".
Comment 1 Eclipse Genie CLA 2017-09-07 12:39:02 EDT 
New Gerrit change created: https://git.eclipse.org/r/104671
Comment 2 Eclipse Genie CLA 2017-09-08 05:49:15 EDT 
New Gerrit change created: https://git.eclipse.org/r/104723
Comment 3 Pierre-Charles David CLA 2017-09-11 04:49:40 EDT 
Created attachment 270144 [details]
Sample project to reproduce the issue

Steps to reproduce/validate:
1. Import the attached project and open the diagram (EcoreTools must be installed).
2. Select the supertype reference (which does not have a label) and right-click: in the "Show/Hide" menu the "Hide label" is NOT available (OK). The action is also not present in the tabbar.
3. Select references "a" and "b" (which both have labels) and right-click: in the "Show/Hide" menu the "Hide label" is available (OK). Same in the tabbar.
4. Select "a" (and/or "b)" *and* the supertype reference: the "Hide label" action is not available, neither in the tabbar not in the context menu, but it could/should. It will simply have no effect on the supertype reference.
Comment 7 Laurent Redor CLA 2017-09-25 05:23:19 EDT 
There is always a problem when a Note or a Text is on the selection.

Steps to reproduce:
* Use same as commment 3 but add a Note and/or a Text in the diagram and select it.
* The selection of Note and/or Text in addition to other elements should not change anything.
Comment 8 Eclipse Genie CLA 2017-09-25 05:45:24 EDT 
New Gerrit change created: https://git.eclipse.org/r/105685
Comment 10 Pierre-Charles David CLA 2017-11-08 03:37:12 EST 
Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.