Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 521230

Summary:	Remove sysouts from DotExecutableUtils and make exception messages accessible.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF DOT	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	5.0.0
Target Milestone:	5.0.1 (Oxygen.1) RC1
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2017-08-22 04:52:11 EDT

Currently, DotExecutableUtils reports status messages on the standard output and standard error streams. Moreover, in case of an exception during program execution (permission denied, etc.) the exception message is not returned by DotExecutableUtils, but only written to stdout.

In order to be usable when the standard output and error streams should not contain information about the Graphviz dot execution, as well as improving performance, no status messages should be written to the standard output or error streams.

In order to be able to properly react to errors, in case of an exception, the exception message should be returned as error output, instead of printing to stdout.

Comment 1 Matthias Wienand

2017-08-22 05:44:23 EDT

I removed all sysout and syserr statements from DotExecutableUtils and ensured that, in case of an exception, the exception message is returned as error output. The code is published on the master and R5_0_0_maintenance branches, therefore, I resolve this ticket as fixed for Oxygen.1 RC1.