Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 521149

Summary:	Add DOT Attribute support for fixedsize=""
Product:	[Tools] GEF	Reporter:	Tamas Miklossy <miklossy>
Component:	GEF DOT	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	5.0.1 (Oxygen.1) RC1
Hardware:	PC
OS:	Windows NT
Whiteboard:

Description Tamas Miklossy

2017-08-19 08:25:25 EDT

Rendering the following dot file http://www.graphviz.org/content/philo within the DOT Graph view results in the following error message:  Could not import DOT: Cannot set node attribute 'fixedsize' to ''. The value '' is not a syntactically correct bool.

Although this is not documented explicitly, empty fixedsize attribute seems to be used/supported by the dot language, especially if the dot file is generated by Graphviz.

It seems there has been a similar issue with the Dot 'style' and 'color' attributes as well: 
https://github.com/eclipse/gef/commit/c060eafdae6cdb97adb4d3b6c973b20e099de30c
https://github.com/eclipse/gef/commit/20e8ee5a47759f661a2675be4b4d239e8b070d07

Comment 1 Tamas Miklossy

2017-08-19 08:34:17 EDT

The following changes are published on the origin/R5_0_0_maintenance and origin/master branches:

I pushed the following changes to origin/master:

[521149] Ensure that Dot Files with fixedsize="" are properly rendered.

- Modify the DotAttributes validateAttributeRawValue method to consider
an empty fixedsize dot attribute value as valid.
- Add philo.dot example file to demonstrate the corresponding use case.
- Implement corresponding DotParserTests test case.

https://github.com/eclipse/gef/commit/517e8adf146248bee7dafa93af40a4748b09d105