Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 520919

Summary:	Add DOT Attribute support for color=""
Product:	[Tools] GEF	Reporter:	Tamas Miklossy <miklossy>
Component:	GEF DOT	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	5.0.1 (Oxygen.1) RC1
Hardware:	PC
OS:	Windows NT
Whiteboard:

Description Tamas Miklossy

2017-08-13 05:19:56 EDT

Rendering the following dot file http://www.graphviz.org/content/ER within the DOT Graph view results in the following error message:  Could not import DOT: Cannot set node attribute 'color' to ''. The value '' is not a syntactically correct color.

Although this is not documented explicitly, empty color attribute seems to be used/supported by the dot language, especially if the dot file is generated by Graphviz.

Comment 1 Tamas Miklossy

2017-08-18 02:31:00 EDT

It seems there has been a similar issue with the Dot 'style' attribute: https://github.com/eclipse/gef/commit/c060eafdae6cdb97adb4d3b6c973b20e099de30c

Comment 2 Tamas Miklossy

2017-08-19 06:58:43 EDT

The following changes are published on the origin/R5_0_0_maintenance and origin/master branches:

[520919] Ensure that Dot Files with color="" are properly rendered.

- Modify the DotColor.xtext grammar to accept an empty color value.
- Add er.dot example file to demonstrate the corresponding use case.
- Implement corresponding DotParserTests test case.
- Adapt the DotAttributesTests and DotContentAssistantTests test cases.