Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 520881

Summary: Impossible to create an edge with associated border nodes to the opposite sides of source and target nodes
Product: [Modeling] Sirius Reporter: Laurent Redor <laurent.redor>
Component: DiagramAssignee: Laurent Redor <laurent.redor>
Status: CLOSED FIXED QA Contact: Julien Dupont <julien.dupont>
Severity: normal    
Priority: P3 CC: julien.dupont, maxime.porhel
Version: 4.1.1Keywords: triaged
Target Milestone: 5.1.0   
Hardware: PC   
OS: Windows NT   
See Also: https://git.eclipse.org/r/102958
https://git.eclipse.org/r/103252
https://git.eclipse.org/r/103251
https://git.eclipse.org/r/103254
https://git.eclipse.org/r/103253
https://git.eclipse.org/r/103401
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=69c1fb1fbcd980be8282cc8ac84ce8b3f4996202
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=13b05cd1d99cceae86c94241d333dcd79f489d04
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4ffdecbf8a4dde5b7217e1657269d694030e4986
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=add47270fc166182e7cc4ee6f777661fb0109ecd
https://git.eclipse.org/r/103811
https://git.eclipse.org/r/103827
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e1ae600bf4fffac27293e8c038528231b1ec734f
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f0533314c48f8a4ee74573a5a212c6ad91aa15ab
https://git.eclipse.org/r/104049
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=77b3242b427be9319d4bff84e4c7f4e1ec3a55ed
Whiteboard:
Attachments:
Description Flags
EdgeCreationPositionTest.zip none

Description Laurent Redor CLA 2017-08-11 04:22:24 EDT
Created attachment 269798 [details]
EdgeCreationPositionTest.zip

The edge is always created and attached to the nearer sides of the source and target nodes (even without or with associated border nodes).
The goal of this issue is to create the border nodes near the locations clicked by the user. So the behavior will be different for the creation of a simple edge and the creation of an edge with its associated border nodes.

This bug is here since the bug 435507.

Steps to reproduce:
* Import the project EdgeCreationPositionTest from EdgeCreationPositionTest.zip (extracted from test data of org.eclipse.sirius.tests.swtbot.EdgeCreationPositionTest)
* Open the diagram "Node"
* Ensure the snap to grid and snap to shape are disabled
* Use the tool "Super" and create an edge between the top left corner of A and the bottom right corner of B
* OK: The edge is created by respecting the shortest way. For information, it is not possible for an edge to "cut/pass trough" its source or target.
* Undo the previous edge creation
* Use the tool "SuperWithBorderNode" and create an edge (and its associated border nodes) between the top left corner of A and the bottom right corner of B
* KO: The border nodes are created at the extremity of the edge like in above scenario. In this case, they can be created near the clicked locations.
* Undo the previous edge creation
* Enable the snap to grid with a grid spacing of 25 pixels
* Use the tool "Super" and create an edge between the top left corner of A and the bottom right corner of B
* OK: The edge is created by respecting the shortest way and the extremity is on the grid
* Undo the previous edge creation
* Use the tool "SuperWithBorderNode" and create an edge (and its associated border nodes) between the top left corner of A and the bottom right corner of B
* KO: The border nodes are created at the extremity of the edge like in above scenario. In this case, they can be created near the clicked locations and snapped to the grid.
Comment 1 Eclipse Genie CLA 2017-08-11 08:44:21 EDT
New Gerrit change created: https://git.eclipse.org/r/102958
Comment 2 Eclipse Genie CLA 2017-08-17 12:20:51 EDT
New Gerrit change created: https://git.eclipse.org/r/103252
Comment 3 Eclipse Genie CLA 2017-08-17 12:20:54 EDT
New Gerrit change created: https://git.eclipse.org/r/103251
Comment 4 Eclipse Genie CLA 2017-08-17 12:20:57 EDT
New Gerrit change created: https://git.eclipse.org/r/103254
Comment 5 Eclipse Genie CLA 2017-08-17 12:20:59 EDT
New Gerrit change created: https://git.eclipse.org/r/103253
Comment 6 Eclipse Genie CLA 2017-08-21 12:45:52 EDT
New Gerrit change created: https://git.eclipse.org/r/103401
Comment 11 Eclipse Genie CLA 2017-08-29 04:11:53 EDT
New Gerrit change created: https://git.eclipse.org/r/103811
Comment 12 Eclipse Genie CLA 2017-08-29 05:26:55 EDT
New Gerrit change created: https://git.eclipse.org/r/103827
Comment 15 Eclipse Genie CLA 2017-08-31 03:40:11 EDT
New Gerrit change created: https://git.eclipse.org/r/104049
Comment 17 Pierre-Charles David CLA 2017-11-08 03:37:10 EST
Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.