Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 520598

Summary:	Register the generated DOT sub-grammar Ecore packages via extension point.
Product:	[Tools] GEF	Reporter:	Tamas Miklossy <miklossy>
Component:	GEF DOT	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	5.0.1 (Oxygen.1) RC1
Hardware:	PC
OS:	Windows NT
Whiteboard:

Description Tamas Miklossy

2017-08-06 06:12:56 EDT

Currently, the generated DOT sub-grammar Ecore packages are registered programatically (see the register...Package() methods in the DotValidatorTests.java class).

Without this registration, some DotValidatorTests (even if executed as Plugin-Tests) fails with the following error message: "DotAttributes: parsedType cannot be determined for grammar: org.eclipse.gef.dot.internal.language.DotArrowType".

However, the EMF Framework provides the org.eclipse.emf.ecore.generated_package extension point to register such generated packages.

Comment 1 Tamas Miklossy

2017-08-06 06:23:11 EDT

The following changes are published on the origin/R5_0_0_maintenance and origin/master branches:

[520598] Use extension point for DOT sub-grammar package registration.

- Merge the org.eclipse.gef.dot/plugin.xml_gen (generated by the Xtext
framework) into the org.eclipse.gef.dot/plugin.xml file to properly
register the generated DOT sub-grammar Ecore packages via the
"org.eclipse.emf.ecore.generated_package" extension point. This makes
the Dot test cases more stable and robust.
- Eliminate the programmatic EPackage registrations from the
DotValidatorTests.java file, since this is not necessary any more.