Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 520582

Summary: Add check on calls to style provider API
Product: [ECD] Orion Reporter: Casey Flynn <caseyflynn>
Component: ClientAssignee: Casey Flynn <caseyflynn>
Status: RESOLVED FIXED QA Contact: Casey Flynn <caseyflynn>
Severity: normal    
Priority: P3 CC: kangy, Michael_Rennie, wilford
Version: 15.0   
Target Milestone: 16.0   
Hardware: PC   
OS: Linux   
See Also: https://github.com/eclipse/orion.client/pull/135
Whiteboard:

Description Casey Flynn CLA 2017-08-04 12:34:40 EDT
There are a few calls to the container style provider that follow the pattern:

if (this.provider) {
  this.provider.getStyles().then(...)
}

We should verify the provider is providing the function getStyles before calling it.
Comment 1 Eclipse Genie CLA 2017-08-04 12:39:58 EDT
GitHub Pull Request 135 created by [caseyflynn-google]
https://github.com/eclipse/orion.client/pull/135
Comment 2 Michael Rennie CLA 2017-08-09 10:17:22 EDT
The PR has been merged. Closing.