| Summary: | Exceptions when dropping non-model files into the aird editor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Jessy Mallet <jessy.mallet> | ||||||
| Component: | Core | Assignee: | Pierre-Charles David <pierre-charles.david> | ||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | florian.barbin, laurent.redor, pierre-charles.david | ||||||
| Version: | 5.0.0 | Keywords: | triaged | ||||||
| Target Milestone: | 5.1.0 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=517532 https://git.eclipse.org/r/103459 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8e96cc411a8e3a2d5bf2bf36a064fb3eb5444fba |
||||||||
| Whiteboard: | need_test | ||||||||
| Attachments: |
|
||||||||
Created attachment 269694 [details]
Trace of exception
Issue accepted and marked as triaged. Caused by https://bugs.eclipse.org/bugs/show_bug.cgi?id=517532 not properly filtering its input. It should probably have been reopened instead of a new ticket created, but too late now. New Gerrit change created: https://git.eclipse.org/r/103459 Gerrit change https://git.eclipse.org/r/103459 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=8e96cc411a8e3a2d5bf2bf36a064fb3eb5444fba Fixed by 8e96cc411a8e3a2d5bf2bf36a064fb3eb5444fba, but still needs a non-regression test. Closing with the need_test keyword: for the "parent" ticket https://bugs.eclipse.org/bugs/show_bug.cgi?id=517532 we were not able to create a test that works reliably on all systems. Validated on Sirius Stable 5.1.0.201709221508 Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0. |
Created attachment 269693 [details] Test case to use. In air editor, on the models block, when user add a txt file (or other file which is not a model) with button "Add..." , nothing happened on the editor. Worst, an error appears in the errorLog view (see stackTrace joined). It would be pleasant if add action opens an error message window to explained the problem instead of error in errorLog view. Step to reproduce : * import in your workspace the modeling project AddFileInEditor.zip, * open aird file with the aird editor, * on the models block of the aird editor, add the file myTest.txt with the "Add..." button, * nothing happened on aird editor and error occurs in errorLog -> KO