Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 520572

Summary: CustomWidgetDescriptionConverter does not translate name to identifier
Product: [Modeling] Sirius Reporter: Pierre-Charles David <pierre-charles.david>
Component: PropertiesAssignee: Pierre-Charles David <pierre-charles.david>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: claudiai, jonathan.hoeges, maxime.porhel, pierre-charles.david
Version: 5.0.0Keywords: triaged
Target Milestone: 5.0.2   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/102601
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b1c1fbf639eec60e6fef58d482e0b7b48d33f8c0
Whiteboard:
Bug Depends on: 519552    
Bug Blocks:    

Description Pierre-Charles David CLA 2017-08-04 09:15:10 EDT 
+++ This bug was initially created as a clone of Bug #519552 +++

The converter for custom property widget descriptions (org.eclipse.sirius.properties.core.internal.converter.CustomWidgetDescriptionConverter) uses a generic method to copy all attributes to the EEF model. This leaves the 'identifier' attribute null since it does no longer exist in the Sirius model (now named 'name'). Child elements (e.g. custom expressions) are also affected.
The TextDescriptionConverter does it correctly: 
eefTextDescription.setIdentifier(textDescription.getName());

Observed in version 5.0.1
Comment 1 Pierre-Charles David CLA 2017-08-04 09:15:34 EDT 
Clone to backport the fix on maintenance version 5.0.2.
Comment 2 Eclipse Genie CLA 2017-08-07 08:36:37 EDT 
New Gerrit change created: https://git.eclipse.org/r/102601
Comment 4 Pierre-Charles David CLA 2017-08-16 05:10:28 EDT 
Fixed by b1c1fbf639eec60e6fef58d482e0b7b48d33f8c0.
Comment 5 Pierre-Charles David CLA 2017-09-11 04:21:17 EDT 
I'm marking as verified on 5.0.2rc2. I had to verify the behavior in debug, as the original report does not indicate how the bug translates in user-visible terms, and the EEF model instances (resulting from the conversion) are not serialized or easily accessible otherwise.
Comment 6 Pierre-Charles David CLA 2017-09-11 10:07:50 EDT 
Available in Sirius 5.0.2.