Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 520565

Summary:	Form title not refreshed on empty selection
Product:	[Modeling] Sirius	Reporter:	Pierre-Charles David <pierre-charles.david>
Component:	Properties	Assignee:	Pierre-Charles David <pierre-charles.david>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	julien.dupont, laurent.redor, pierre-charles.david, william.piers
Version:	4.0.0	Keywords:	triaged
Target Milestone:	5.0.2
Hardware:	PC
OS:	Windows NT
Whiteboard:
Bug Depends on:	519637
Bug Blocks:

Description Pierre-Charles David

2017-08-04 08:01:11 EDT

+++ This bug was initially created as a clone of Bug #519637 +++

This issue only occurs in custom RCP context: within eclipse it seems that the selection is never empty.
But when it is the case, the property page is correctly emptied from its sections but the form title keeps the text from the last selection.
This is due to (in org.eclipse.sirius.ui.properties.internal.ContributorWrapper.updateFormTitle):
 Object element = structuredSelection.getFirstElement(); if (element == null) { return; }
Before returning null it might be better to reset the title & image with:
 form.setText(""); form.setImage(null);

Comment 1 Pierre-Charles David

2017-08-04 08:01:55 EDT

Clone to backport the fix for maintenance version 5.0.2.

Comment 2 Pierre-Charles David

2017-08-04 08:46:34 EDT

Fixed by 0e1cf1d089a7c5cadd0a48151908fbbcae9a9b37, cherry-picked from a5e634fe1f011a08bd9c33448b6849087611c249 which fixed the bug on master.

Comment 3 Pierre-Charles David

2017-09-11 10:07:51 EDT

Available in Sirius 5.0.2.