Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 520450

Summary:

[Glance] Custom painting broken when glance is activated

Product:

[Eclipse Project] e4

Reporter:

Thomas Wolf <twolf>

Component:

Assignee:

Project Inbox <e4.ui-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

skanton

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

All

See Also:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=520413
https://git.eclipse.org/r/102880
https://git.eclipse.org/c/e4/org.eclipse.e4.ui.git/commit/?id=0c1d95f58c75eba40013a47523ef7186486d33a0

Whiteboard:

Attachments:

Description	Flags
Screenshot of history view: branch graphics are overdrawn by text	none
New glance behavior for custom painting	none

Description Thomas Wolf

2017-08-02 07:12:15 EDT

Created attachment 269644 [details]
Screenshot of history view: branch graphics are overdrawn by text

Glance hooks into paint events and thereby breaks custom painting as is done for instance in the EGit history view. Even using the fork at https://github.com/cypher256/glance (which fixes bug 520413), Glance re-draws the text over the branch graphics, and branches and tags are no longer shown.

Comment 1 Eclipse Genie

2017-08-10 09:12:58 EDT

New Gerrit change created: https://git.eclipse.org/r/102880

Comment 2 Eclipse Genie

2017-08-10 09:16:23 EDT

Gerrit change https://git.eclipse.org/r/102880 was merged to [master].
Commit: http://git.eclipse.org/c/e4/org.eclipse.e4.ui.git/commit/?id=0c1d95f58c75eba40013a47523ef7186486d33a0

Comment 3 Anton Salnik

2017-08-10 09:30:07 EDT

Created attachment 269790 [details]
New glance behavior for custom painting

Glance can't restore initial state of elements in case of custom painting without internal knowledge of target component. Now glance just marks all cells that contain matched text in the case.