Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 520110

Summary: Do not automatically scroll diagram when element is selected
Product: [Modeling] Sirius Reporter: Laurent Fasani <laurent.fasani>
Component: DiagramAssignee: Laurent Redor <laurent.redor>
Status: CLOSED FIXED QA Contact: Julien Dupont <julien.dupont>
Severity: enhancement    
Priority: P3 CC: julien.dupont, laurent.redor, pierre-charles.david
Version: unspecifiedKeywords: triaged
Target Milestone: 5.1.0   
Hardware: PC   
OS: All   
See Also: https://git.eclipse.org/r/95150
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a8295012e10299b30dbbe3f9be6f696504bf1dbc
https://git.eclipse.org/r/103825
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d58dfccb9c1394afa6e1af6e01c7831d2842c39e
https://git.eclipse.org/r/110497
https://bugs.eclipse.org/bugs/show_bug.cgi?id=526369
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1e2ba503d022495457834ae5f76f8de853e89b98
Whiteboard:
Attachments:
Description Flags
testRevealAfterSelection project
none
scenario_elements_to_select
none
Video showing the issue with border nodes none

Description Laurent Fasani CLA 2017-07-24 11:24:16 EDT 
If i select an big edge or a big node on diagram, the scroll is automatic and focus centered on it: *even if i would like to see only the name (Properties View) of this incoming edge or node*... than i have to re-center my diagram on my original position.
See video

*Do not automatically scroll by default (or provide a way to select element without scrolling (shortcut?)). Both behaviors are interesting but sometimes the original one is irritating*
Comment 1 Laurent Fasani CLA 2017-07-24 11:30:27 EDT 
The chosen behavior is to not reveal the selected node or edge.
This behavior is not to be disabled because, if the user wants to see the entire selected node, it is easy to use the center button mouse to move the diagram.
Comment 2 Laurent Fasani CLA 2017-07-25 08:22:02 EDT 
added:
https://git.eclipse.org/r/95150 [520110] Disable reveal on node and edge selection
Comment 3 Laurent Fasani CLA 2017-07-25 09:15:48 EDT 
scenario with attached projet:
If you have org.eclipse.sirius.sample.ecore.design deployed on your runtime:
- import attached project testRevealAfterSelection
- open the diagram
- select NewClass1 node -> The editor content should not have moved (scroll bars position have not changed)
- select [0..1]ref edge-> The editor content should not have moved (scroll bars position have not changed)


alternative scenario:
- create a diagram with two node linked with an edge
- enlarge and move one node so that it is not fully displayed in the edior
- move the edge anchor on that node so that it is not visible
- open diagram ...
Comment 4 Laurent Fasani CLA 2017-07-26 05:04:47 EDT 
Created attachment 269539 [details]
testRevealAfterSelection project
Comment 6 Laurent Fasani CLA 2017-08-02 12:23:46 EDT 
Created attachment 269660 [details]
scenario_elements_to_select
Comment 7 Laurent Fasani CLA 2017-08-02 12:25:05 EDT 
Homologation/scenario

see attached "scenario_elements_to_select" image to better see the node and edge to select
Comment 8 Laurent Redor CLA 2017-08-24 03:33:28 EDT 
There is a regression since the commit a829501 [1].
Steps to reproduce:
* Create a modeling project with an Interaction model
* Enable the viewpoint "Interactions"
* Create a Sequence diagram 
* Create 2 lifelines with one execution on each lifeline
* Create a read message bewteen the 2 executions
* Move the message
* KO: the grey feedback remains visible
* Move the message
* KO: a second grey feedback remains visible (and so on)

[1] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a8295012e10299b30dbbe3f9be6f696504bf1dbc
Comment 9 Eclipse Genie CLA 2017-08-29 04:54:01 EDT 
New Gerrit change created: https://git.eclipse.org/r/103825
Comment 11 Pierre-Charles David CLA 2017-10-20 10:07:17 EDT 
Created attachment 271119 [details]
Video showing the issue with border nodes

It does not seem to work for border nodes, see the attached video.
Comment 12 Pierre-Charles David CLA 2017-10-20 10:07:55 EDT 
It does not seem to work for border nodes, see the attached video.
Comment 13 Eclipse Genie CLA 2017-10-23 03:24:01 EDT 
New Gerrit change created: https://git.eclipse.org/r/110497
Comment 14 Laurent Redor CLA 2017-10-23 10:22:00 EDT 
The case of border nodes will be finally fixed in Sirius 5.1.1. It is too late to integrate it in Sirius 5.1.0.
Comment 15 Laurent Redor CLA 2017-10-23 10:30:54 EDT 
The other issue to deal with last problem is bug 526369.

There is so nothing new to validate in scope of this issue.
Comment 16 Pierre-Charles David CLA 2017-11-08 03:37:37 EST 
Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.