Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 520099

Summary: [GTK3] Unexpected separator lines in view toolbars
Product: [Eclipse Project] Platform Reporter: Andrey Loskutov <loskutov>
Component: SWTAssignee: Platform-SWT-Inbox <platform-swt-inbox>
Status: CLOSED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: ericwill
Version: 4.8   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=519321
https://bugs.eclipse.org/bugs/show_bug.cgi?id=483493
Whiteboard:
Attachments:
Description Flags
view toolbar comparison 4.6.3 vs 4.8 none

Description Andrey Loskutov CLA 2017-07-24 08:34:29 EDT 
Created attachment 269508 [details]
view toolbar comparison 4.6.3 vs 4.8

Regression in 4.8, most likely coming from bug 519321 changes.

The toolbars of views have some strange "separator" lines, see the attached picture.
Comment 1 Eric Williams CLA 2017-07-24 10:47:04 EDT 
This bug has been around for awhile on GTK3.16+, see:

bug 497829
&
bug 483493.

Still not sure if it's an SWT or Platform UI issue. When I original switched GTK3.16+ background machinery to CSS, I did not see it. Shortly after a change in Platform UI introduced the white line.

That said, it didn't appear on GTK3.14 until 3.14 started using GTK CSS as well. It could be a case of incorrect behaviour before, and now correct behaviour is showing the bug. It could also be the opposite.
Comment 2 Andrey Loskutov CLA 2017-07-24 10:50:44 EDT 
(In reply to Eric Williams from comment #1)
> This bug has been around for awhile on GTK3.16+, see:

I'm on 3.14 and this is a regression from 4.8.
 
> That said, it didn't appear on GTK3.14 until 3.14 started using GTK CSS as
> well. It could be a case of incorrect behaviour before, and now correct
> behaviour is showing the bug. It could also be the opposite.

Yes, but still this is a regression for users of 3.14. So should we make it duplicate of bug 483493 or not?
Comment 3 Eric Williams CLA 2017-07-24 10:55:22 EDT 
(In reply to Andrey Loskutov from comment #2)
> (In reply to Eric Williams from comment #1)
> > This bug has been around for awhile on GTK3.16+, see:
> 
> I'm on 3.14 and this is a regression from 4.8.
>  
> > That said, it didn't appear on GTK3.14 until 3.14 started using GTK CSS as
> > well. It could be a case of incorrect behaviour before, and now correct
> > behaviour is showing the bug. It could also be the opposite.
> 
> Yes, but still this is a regression for users of 3.14. So should we make it
> duplicate of bug 483493 or not?

I'm going to mark it as a duplicate. I'll probably be the one investigating it anyways, so if it does turn out to be SWT's fault I'll move bug 483493 then.

*** This bug has been marked as a duplicate of bug 483493 ***