Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 519783

Summary:	HTMLPrinter should migrate to StringBuilder
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	Text	Assignee:	Shawn Kleese <shawn.kleese>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	akurtakov, daniel_megert, gautier.desaintmartinlacaze, Lars.Vogel, shawn.kleese
Version:	4.3
Target Milestone:	4.8 M5
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/101394 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=09a178219245fd3470f0f290b1a05b4e4647e0f8 https://git.eclipse.org/r/113135 https://git.eclipse.org/r/113136 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=65902ae8b52e65f39c05757cac1750206186e18a https://git.eclipse.org/r/113458 https://git.eclipse.org/r/113459 https://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=cbc1ea0749bfac8cdf1f1a86c56e033f3c6899fa https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=da6623602e470797e52f788591707cde85a3ee75 https://git.eclipse.org/r/115647 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=432db08619cda4364032721bf730f48194237ce6 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=7eb24aaae3dbc3e92aa76bc3407fa3bd7128c595
Whiteboard:
Bug Depends on:
Bug Blocks:	529118, 530240

Description Lars Vogel

2017-07-17 14:47:08 EDT

HTMLPrinter is internal API we can change it.

Comment 1 Eclipse Genie

2017-07-17 15:30:39 EDT

New Gerrit change created: https://git.eclipse.org/r/101394

Comment 2 Eclipse Genie

2017-12-11 03:42:18 EST

Gerrit change https://git.eclipse.org/r/101394 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=09a178219245fd3470f0f290b1a05b4e4647e0f8

Comment 3 Lars Vogel

2017-12-11 04:50:58 EST

The old methods should be removed once we migrated PDE and JDT. I suggest to use this bug for this.

Comment 4 Eclipse Genie

2017-12-11 05:01:45 EST

New Gerrit change created: https://git.eclipse.org/r/113135

Comment 5 Eclipse Genie

2017-12-11 05:13:22 EST

New Gerrit change created: https://git.eclipse.org/r/113136

Comment 6 Eclipse Genie

2017-12-12 14:35:52 EST

Gerrit change https://git.eclipse.org/r/113135 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=65902ae8b52e65f39c05757cac1750206186e18a

Comment 7 Eclipse Genie

2017-12-15 04:21:45 EST

New Gerrit change created: https://git.eclipse.org/r/113458

Comment 8 Eclipse Genie

2017-12-15 04:23:57 EST

New Gerrit change created: https://git.eclipse.org/r/113459

Comment 9 Eclipse Genie

2017-12-15 04:37:48 EST

New Gerrit change created: https://git.eclipse.org/r/113461

Comment 10 Eclipse Genie

2017-12-15 04:49:38 EST

Gerrit change https://git.eclipse.org/r/113458 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=cbc1ea0749bfac8cdf1f1a86c56e033f3c6899fa

Comment 11 Noopur Gupta

2017-12-15 05:12:12 EST

*** Bug 528734 has been marked as a duplicate of this bug. ***

Comment 12 Eclipse Genie

2017-12-15 12:34:29 EST

New Gerrit change created: https://git.eclipse.org/r/113495

Comment 13 Eclipse Genie

2017-12-16 07:20:24 EST

New Gerrit change created: https://git.eclipse.org/r/113524

Comment 14 Eclipse Genie

2017-12-20 05:24:51 EST

Gerrit change https://git.eclipse.org/r/113136 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=da6623602e470797e52f788591707cde85a3ee75

Comment 15 Alexander Kurtakov

2018-01-18 08:11:27 EST

Lars, is this one done?

Comment 16 Lars Vogel

2018-01-18 08:24:10 EST

(In reply to Alexander Kurtakov from comment #15)
> Lars, is this one done?

Not sure what you mean. AFAIK we still need to remove the old methods from the internal API. I will check tonight (currently with a customer).

Comment 17 Eclipse Genie

2018-01-18 11:47:00 EST

New Gerrit change created: https://git.eclipse.org/r/115647

Comment 18 Eclipse Genie

2018-01-18 16:03:48 EST

Gerrit change https://git.eclipse.org/r/113459 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=432db08619cda4364032721bf730f48194237ce6

Comment 19 Eclipse Genie

2018-01-18 16:03:50 EST

Gerrit change https://git.eclipse.org/r/115647 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=7eb24aaae3dbc3e92aa76bc3407fa3bd7128c595

Comment 20 Lars Vogel

2018-01-18 16:05:22 EST

Thanks again, Shawn. 

I delete the temporary deprecated internal methods. I did check if they are used in the SDK, lets see if there are any other usages outside the bundled SDK.