| Summary: | Form title not refreshed on empty selection | ||
|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | William Piers <william.piers> |
| Component: | Properties | Assignee: | Laurent Redor <laurent.redor> |
| Status: | CLOSED FIXED | QA Contact: | Laurent Redor <laurent.redor> |
| Severity: | normal | ||
| Priority: | P3 | CC: | julien.dupont, laurent.redor, pierre-charles.david |
| Version: | 4.0.0 | Keywords: | triaged |
| Target Milestone: | 5.1.0 | ||
| Hardware: | PC | ||
| OS: | Windows NT | ||
| See Also: |
https://git.eclipse.org/r/102470 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a5e634fe1f011a08bd9c33448b6849087611c249 |
||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 520565 | ||
New Gerrit change created: https://git.eclipse.org/r/102470 Gerrit change https://git.eclipse.org/r/102470 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=a5e634fe1f011a08bd9c33448b6849087611c249 Can not be verified: missing or incomplete reproduction information. Indeed Julien, there is no reproduction case as this bug only occurs in RCP context. William has already validated this issue in its RCP context (see his comment on https://git.eclipse.org/r/#/c/102470/). Already verified by William. Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0. |
This issue only occurs in custom RCP context: within eclipse it seems that the selection is never empty. But when it is the case, the property page is correctly emptied from its sections but the form title keeps the text from the last selection. This is due to (in org.eclipse.sirius.ui.properties.internal.ContributorWrapper.updateFormTitle): Object element = structuredSelection.getFirstElement(); if (element == null) { return; } Before returning null it might be better to reset the title & image with: form.setText(""); form.setImage(null);