Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 519611

Summary:	[lsp] DocumentHighlightKind is ignored for 'textDocument/documentHighlight' requests
Product:	[ECD] Orion	Reporter:	Remy Suen <remy.suen>
Component:	Client	Assignee:	Remy Suen <remy.suen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Olivier_Thomann
Version:	unspecified
Target Milestone:	16.0
Hardware:	All
OS:	All
Whiteboard:

Description Remy Suen

2017-07-13 06:49:56 EDT

At the moment, we support highlighting occurrences. However, only the range of the server's response is considered.

https://github.com/eclipse/orion.client/blob/7b5e2ca26342f34711cb90bbca59eae472f3c6c1/bundles/org.eclipse.orion.client.ui/web/orion/lsp/utils.js#L81-L85

We should be reading the 'kind' property to determine if it's a DocumentHighlightKind.Read or a DocumentHighlightKind.Write and mark it as such in the created annotation object.

Comment 1 Remy Suen

2017-07-13 07:33:45 EDT

Fix pushed to the java-lsp branch.

https://github.com/eclipse/orion.client/commit/b289ea0aeb122e2b415d625cd1c3de2283da56cc