Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 519584

Summary:	HTML parser stores tag attributes as a map, but should be array
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3
Version:	14.0
Target Milestone:	16.0
Hardware:	PC
OS:	Mac OS X
See Also:	https://github.com/eclipse/orion.client/pull/111
Whiteboard:

Description Michael Rennie

2017-07-12 16:54:59 EDT

During the AST creation phase, we are storing tag attribute nodes in a map (based on their name), which means if there is a duplicate attribute, it is not present in the AST.

Even though duplicate attributes are discouraged, the AST should always directly map back to all source elements (when possible).

This fix will also require changes to the HTML validator rule that checks for duplicate attributes.

Comment 1 Eclipse Genie

2017-07-12 17:51:41 EDT

GitHub Pull Request 111 created by [mrennie]
https://github.com/eclipse/orion.client/pull/111

Comment 2 Michael Rennie

2017-07-12 17:52:37 EDT

Merged - I fixed the parser, validation rules and tests.