Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 519552

Summary:	CustomWidgetDescriptionConverter does not translate name to identifier
Product:	[Modeling] Sirius	Reporter:	Jonathan HÃ¶ges <jonathan.hoeges>
Component:	Properties	Assignee:	Project Inbox <sirius.properties-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	claudiai, jonathan.hoeges, julien.dupont, maxime.porhel, pierre-charles.david
Version:	5.0.0	Keywords:	triaged
Target Milestone:	5.1.0
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/101701 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=32f641c4a2b7038084e0f460a2ef0e3d7dfaa1e4
Whiteboard:
Bug Depends on:
Bug Blocks:	520572

Description Jonathan HÃ¶ges

2017-07-12 09:21:21 EDT

The converter for custom property widget descriptions (org.eclipse.sirius.properties.core.internal.converter.CustomWidgetDescriptionConverter) uses a generic method to copy all attributes to the EEF model. This leaves the 'identifier' attribute null since it does no longer exist in the Sirius model (now named 'name'). Child elements (e.g. custom expressions) are also affected.
The TextDescriptionConverter does it correctly: 
eefTextDescription.setIdentifier(textDescription.getName());

Observed in version 5.0.1

Comment 1 Maxime Porhel

2017-07-13 04:12:35 EDT

Hi Jonathan, 

Thanks for the detailed report, we reckon it is valid. 
Nevertheless, it's not yet in the scope of a future release.

Regards,

Comment 2 Jonathan HÃ¶ges

2017-07-13 04:32:42 EDT

This breaks all custom property widgets since they depend on the description identifier in IEEFLifecycleManagerProvider.canHandle(EEFControlDescription controlDescription), so this is a major regression imho.

Comment 3 Eclipse Genie

2017-07-21 05:02:55 EDT

New Gerrit change created: https://git.eclipse.org/r/101701

Comment 4 Eclipse Genie

2017-08-07 04:34:22 EDT

Gerrit change https://git.eclipse.org/r/101701 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=32f641c4a2b7038084e0f460a2ef0e3d7dfaa1e4

Comment 5 Pierre-Charles David

2017-08-07 04:36:25 EDT

Fixed by 32f641c4a2b7038084e0f460a2ef0e3d7dfaa1e4: all the filtering expression variables were renamed to match the following pattern: featureName+'Description'.

This change will be backported on v5.0.2 via #520572.

Comment 6 Pierre-Charles David

2017-08-07 04:45:53 EDT

(In reply to Pierre-Charles David from comment #5)
> Fixed by 32f641c4a2b7038084e0f460a2ef0e3d7dfaa1e4
> 
> This change will be backported on v5.0.2 via #520572.

Sorry, wrong bug: the explanation about "filtering expression variables" concern bug #519322.

This one is indeed fixed by 32f641c4a2b7038084e0f460a2ef0e3d7dfaa1e4 and will be backported, but the fix has no visible side-effect except fixing the bug.

Comment 7 Julien Dupont

2017-09-20 05:57:19 EDT

Can not be verified: missing or incomplete reproduction information.

Comment 8 Pierre-Charles David

2017-09-25 11:25:30 EDT

Verified in debug, I don't know how to do better since the EEF models are not persited.

Comment 9 Pierre-Charles David

2017-11-08 03:37:50 EST

Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.