Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 519524

Summary:	[lsp] textDocument/definition responses are assumed to be Location arrays
Product:	[ECD] Orion	Reporter:	Remy Suen <remy.suen>
Component:	Client	Assignee:	Remy Suen <remy.suen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Olivier_Thomann
Version:	unspecified
Target Milestone:	16.0
Hardware:	All
OS:	All
Whiteboard:

Description Remy Suen

2017-07-11 16:38:32 EDT

Per the spec, textDocument/definition can return a Location or a Location[]. However, the current code assumes that a Location[] is returned and any language server that returns a Location will get its response effectively ignored in Orion.

https://github.com/eclipse/orion.client/blob/edeb7c6363089a8207a92e5bcff0e870295d695d/bundles/org.eclipse.orion.client.ui/web/orion/gotoDefinition.js#L49-L53

Comment 1 Remy Suen

2017-07-11 17:03:37 EDT

Fix pushed to the java-lsp branch.

https://github.com/eclipse/orion.client/commit/7b5e2ca26342f34711cb90bbca59eae472f3c6c1